[Remote Translog] Fix translog inconsistent generation assertion failure in ITs

[ashking94]

Description

As seen in #10902, we can see that during test cleanup, we see an assertion failure that happens due to max reader generation being different than supplied generation. This will fix multiple flaky tests that fail due to this reason.

Related Issues

Resolves #10902

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29220/
• CommitID: 920f744
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Compatibility status:

Checks if related components are compatible with change 6e527d9

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob

• URL: https://build.ci.opensearch.org/job/gradle-check/29227/
• CommitID: 502e3f2
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #10986 (6e527d9) into main (63aff16) will increase coverage by 0.00%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main   #10986   +/-   ##
=========================================
  Coverage     71.29%   71.29%           
- Complexity    58742    58777   +35     
=========================================
  Files          4872     4872           
  Lines        276777   276781    +4     
  Branches      40240    40242    +2     
=========================================
+ Hits         197316   197341   +25     
- Misses        62943    62998   +55     
+ Partials      16518    16442   -76     

Files	Coverage Δ
...rg/opensearch/index/translog/RemoteFsTranslog.java	75.47% <100.00%> (-0.84%)	⬇️
...s/replication/SegmentReplicationTargetService.java	56.17% <100.00%> (+0.56%)	⬆️

... and 483 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29438/
• CommitID: 3f491ad
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[ashking94]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29438/
• CommitID: 3f491ad
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

flaky tests - #10006, #10755

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testAsyncDurabilityWhenRestrictSettingImplicitFalse

• URL: https://build.ci.opensearch.org/job/gradle-check/29442/
• CommitID: 6e527d9
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[ashking94]

org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testAsyncDurabilityWhenRestrictSettingImplicitFalse

Created #11051 for the flaky test

[ashking94]

Closing this in interest of alternate approach -> #10985.