-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add statsName field on stream while constructing PersistedStateStats #10964
Add statsName field on stream while constructing PersistedStateStats #10964
Conversation
Signed-off-by: Aman Khare <[email protected]>
@shwetathareja @Bukhtawar - looking for feedback and review. |
Compatibility status:Checks if related components are compatible with change 3f295e8 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Flaky CardinalityWithRequestBreakerIT - #10154 |
@mch2 ^^ |
server/src/main/java/org/opensearch/cluster/coordination/PersistedStateStats.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Another flaky testCancelReplicationWhileSyncingSegments : #10902 Flaky testThreeNodesNoClusterManagerBlock - #10006 |
…10964) Signed-off-by: Aman Khare <[email protected]> Co-authored-by: Aman Khare <[email protected]> (cherry picked from commit f372cbf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…10964) (#10976) (cherry picked from commit f372cbf) Signed-off-by: Aman Khare <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Aman Khare <[email protected]>
LGTM! |
…pensearch-project#10964) Signed-off-by: Aman Khare <[email protected]> Co-authored-by: Aman Khare <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
_nodes/stats is failing due to recently added cluster state stats. This PR fixes that issue by writing statsName field on the stream and reads from it to properly create the PersistedStateStats object.
Related Issues
Resolves #10961
Check List
- [ ] New functionality has been documented.- [ ] New functionality has javadoc added- [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.