Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statsName field on stream while constructing PersistedStateStats #10964

Merged

Conversation

amkhar
Copy link
Contributor

@amkhar amkhar commented Oct 27, 2023

Description

_nodes/stats is failing due to recently added cluster state stats. This PR fixes that issue by writing statsName field on the stream and reads from it to properly create the PersistedStateStats object.

Related Issues

Resolves #10961

Check List

  • New functionality includes testing.
    • All tests pass
      - [ ] New functionality has been documented.
      - [ ] New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
    - [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amkhar
Copy link
Contributor Author

amkhar commented Oct 27, 2023

@shwetathareja @Bukhtawar - looking for feedback and review.

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 3f295e8

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@amkhar
Copy link
Contributor Author

amkhar commented Oct 27, 2023

Gradle Check (Jenkins) Run Completed with:

Flaky CardinalityWithRequestBreakerIT - #10154
Flaky testThreeNodesNoClusterManagerBlock - #10006

@amkhar
Copy link
Contributor Author

amkhar commented Oct 27, 2023

@mch2 ^^

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@amkhar
Copy link
Contributor Author

amkhar commented Oct 28, 2023

@sachinpkale

Gradle Check (Jenkins) Run Completed with:

Another flaky testCancelReplicationWhileSyncingSegments : #10902

Flaky testThreeNodesNoClusterManagerBlock - #10006

@sachinpkale sachinpkale merged commit f372cbf into opensearch-project:main Oct 28, 2023
42 of 99 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Oct 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2023
…10964)

Signed-off-by: Aman Khare <[email protected]>
Co-authored-by: Aman Khare <[email protected]>
(cherry picked from commit f372cbf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Oct 28, 2023
…10964) (#10976)

(cherry picked from commit f372cbf)

Signed-off-by: Aman Khare <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aman Khare <[email protected]>
@shwetathareja
Copy link
Member

LGTM!

shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cluster State Stats Fails For Multi Node Setup
4 participants