Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Remote Store] Fix refresh lag bug on primary term change #10935

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b17d4a8 from #10918.

* [Remote Store] Fix refresh lag bug on primary term change

Signed-off-by: Ashish Singh <[email protected]>

* Add Integ Tests

Signed-off-by: Ashish Singh <[email protected]>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <[email protected]>

* Empty-Commit

Signed-off-by: Ashish Singh <[email protected]>

---------

Signed-off-by: Ashish Singh <[email protected]>
(cherry picked from commit b17d4a8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change d07d558

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.index.shard.RemoteIndexShardTests.classMethod
      1 org.opensearch.index.shard.RemoteIndexShardTests.testSegRepSucceedsOnPreviousCopiedFiles

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #10935 (d07d558) into 2.x (1d92801) will increase coverage by 0.05%.
Report is 7 commits behind head on 2.x.
The diff coverage is 52.69%.

@@             Coverage Diff              @@
##                2.x   #10935      +/-   ##
============================================
+ Coverage     70.91%   70.96%   +0.05%     
- Complexity    58802    58809       +7     
============================================
  Files          4844     4847       +3     
  Lines        277512   277638     +126     
  Branches      40708    40721      +13     
============================================
+ Hits         196802   197033     +231     
+ Misses        64036    63816     -220     
- Partials      16674    16789     +115     
Files Coverage Δ
...search/cluster/coordination/CoordinationState.java 88.39% <ø> (ø)
.../org/opensearch/cluster/service/MasterService.java 84.51% <100.00%> (-0.56%) ⬇️
...nsearch/gateway/remote/RemotePersistenceStats.java 100.00% <100.00%> (ø)
...in/java/org/opensearch/index/shard/IndexShard.java 69.78% <100.00%> (+0.58%) ⬆️
...earch/index/store/RemoteSegmentStoreDirectory.java 88.84% <ø> (-0.04%) ⬇️
...rc/main/java/org/opensearch/index/store/Store.java 80.68% <100.00%> (-0.18%) ⬇️
...h/cluster/coordination/InMemoryPersistedState.java 68.75% <0.00%> (-4.59%) ⬇️
...search/index/shard/RemoteStoreRefreshListener.java 86.82% <87.50%> (-0.30%) ⬇️
...g/opensearch/cluster/coordination/Coordinator.java 78.57% <77.77%> (+3.43%) ⬆️
.../java/org/opensearch/gateway/GatewayMetaState.java 71.60% <77.77%> (+2.35%) ⬆️
... and 4 more

... and 466 files with indirect coverage changes

@gbbafna gbbafna merged commit 6f41ee8 into 2.x Oct 26, 2023
41 of 67 checks passed
@github-actions github-actions bot deleted the backport/backport-10918-to-2.x branch October 26, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants