Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logging around remote cluster state #10892

Conversation

dhwanilpatel
Copy link
Contributor

@dhwanilpatel dhwanilpatel commented Oct 24, 2023

Description

Improved logging around remote cluster state service. Added info/debug logs.

Related Issues

Check List

  • New functionality includes testing. [Not required]
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog) [Not required]
  • Public documentation issue/PR created [Not required]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Compatibility status:

Checks if related components are compatible with change 9f2bb51

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Dhwanil Patel <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@shwetathareja shwetathareja merged commit d1c94b5 into opensearch-project:main Oct 26, 2023
15 checks passed
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #10892 (9f2bb51) into main (fe8b2d5) will increase coverage by 0.13%.
Report is 1 commits behind head on main.
The diff coverage is 69.23%.

@@             Coverage Diff              @@
##               main   #10892      +/-   ##
============================================
+ Coverage     71.11%   71.24%   +0.13%     
- Complexity    58687    58739      +52     
============================================
  Files          4872     4872              
  Lines        276691   276699       +8     
  Branches      40221    40222       +1     
============================================
+ Hits         196770   197145     +375     
+ Misses        63523    63151     -372     
- Partials      16398    16403       +5     
Files Coverage Δ
...arch/index/recovery/RemoteStoreRestoreService.java 12.80% <0.00%> (-0.11%) ⬇️
...arch/gateway/remote/RemoteClusterStateService.java 71.85% <75.00%> (+0.59%) ⬆️

... and 461 files with indirect coverage changes

@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Oct 26, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2023
* Improved logging around remote cluster state

Signed-off-by: Dhwanil Patel <[email protected]>
(cherry picked from commit d1c94b5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Oct 26, 2023
* Improved logging around remote cluster state

(cherry picked from commit d1c94b5)

Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Improved logging around remote cluster state

Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants