Make index and global metadata upload timeout dynamic cluster settings

[rahulkarajgikar]

Description

• Make remote store index and global metadata upload timeout dynamic
• Adds 2 new dynamically configurable settings, with default value 20s:
  • cluster.remote_store.state.index_metadata.upload_timeout
  • cluster.remote_store.state.global_metadata.upload_timeout

Related Issues

Resolves #10688

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28679/
• CommitID: 8fd9acb
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Compatibility status:

Checks if related components are compatible with change f08c371

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

[rahulkarajgikar]

retrying tests locally:

./gradlew ':server:test' --tests "org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore" -Dtests.iters=10

test failing every time with same error:

java.lang.AssertionError: timed out waiting for yellow state
        at __randomizedtesting.SeedInfo.seed([8C145360427AE77D:1341F63BA44A0E7D]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:1012)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureYellowAndNoInitializingShards(OpenSearchIntegTestCase.java:965)
        at org.opensearch.remotestore.BaseRemoteStoreRestoreIT.verifyRestoredData(BaseRemoteStoreRestoreIT.java:65)
        at org.opensearch.remotestore.BaseRemoteStoreRestoreIT.verifyRestoredData(BaseRemoteStoreRestoreIT.java:89)
        at org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore(RemoteStoreClusterStateRestoreIT.java:162)

Failed all 10 times with these seeds:

 - org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore {seed=[8C145360427AE77D:82616C2453BEFFA8]}
 - org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore {seed=[8C145360427AE77D:3637D0D8677C3484]}
 - org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore {seed=[8C145360427AE77D:B8DE460436B87C4F]}
 - org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore {seed=[8C145360427AE77D:8930EDE15A462766]}
 - org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore {seed=[8C145360427AE77D:C5F1684CFB4EE7DD]}
 - org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore {seed=[8C145360427AE77D:540BBB1386F2AADD]}
 - org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore {seed=[8C145360427AE77D:6AD5DF9594C2BADB]}
 - org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore {seed=[8C145360427AE77D:F66645EFB7D62E75]}
 - org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore {seed=[8C145360427AE77D:C4CAA081C01D392F]}
 - org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore {seed=[8C145360427AE77D:1341F63BA44A0E7D]}

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28736/
• CommitID: cb68ea8
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[rahulkarajgikar]

ongoing PR in review to fix this failing test in main:

https://github.com/opensearch-project/OpenSearch/pull/10838/files

org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterStateRestore

[rahulkarajgikar]

#10838 - fix for failing test is here

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28768/
• CommitID: 5533576
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28769/
• CommitID: 63fe86c
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28770/
• CommitID: cb68ea8
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

• URL: https://build.ci.opensearch.org/job/gradle-check/28771/
• CommitID: 7ed462e
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[rahulkarajgikar]

test failures are flaky:

      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Flaky test tracking issues: #10755 #10558

[shwetathareja]

Documentation needed for the newly added settings

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}

• URL: https://build.ci.opensearch.org/job/gradle-check/28791/
• CommitID: f08c371
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10814-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f13dee77a7e78833cf90b20607cb4d714032bd8
# Push it to GitHub
git push --set-upstream origin backport/backport-10814-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-10814-to-2.x.