-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Fix relocation failure due to transport receive timeout #10761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashking94
requested review from
abbashus,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
peternied,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja,
sohami and
VachaShah
as code owners
October 19, 2023 20:33
ashking94
added
Storage:Durability
Issues and PRs related to the durability framework
backport 2.x
Backport to 2.x branch
labels
Oct 19, 2023
Signed-off-by: Ashish Singh <[email protected]>
Rebasing with main and retrying. |
Bukhtawar
reviewed
Oct 20, 2023
Bukhtawar
reviewed
Oct 20, 2023
server/src/main/java/org/opensearch/indices/recovery/RemoteRecoveryTargetHandler.java
Outdated
Show resolved
Hide resolved
Bukhtawar
reviewed
Oct 20, 2023
server/src/main/java/org/opensearch/indices/recovery/RemoteRecoveryTargetHandler.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ashish Singh <[email protected]>
Signed-off-by: Ashish Singh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10761 +/- ##
============================================
+ Coverage 71.12% 71.25% +0.13%
- Complexity 58545 58659 +114
============================================
Files 4859 4859
Lines 276252 276280 +28
Branches 40191 40196 +5
============================================
+ Hits 196473 196872 +399
+ Misses 63347 63016 -331
+ Partials 16432 16392 -40
|
Bukhtawar
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andrross
approved these changes
Oct 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
#10761) * [Remote Store] Fix relocation failure due to transport receive timeout Signed-off-by: Ashish Singh <[email protected]> * Fix existing extended shardIdle for remote backed shards Signed-off-by: Ashish Singh <[email protected]> * Incorporate PR review comments Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]> (cherry picked from commit a1fde65) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Oct 21, 2023
opensearch-project#10761) * [Remote Store] Fix relocation failure due to transport receive timeout Signed-off-by: Ashish Singh <[email protected]> * Fix existing extended shardIdle for remote backed shards Signed-off-by: Ashish Singh <[email protected]> * Incorporate PR review comments Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Oct 21, 2023
opensearch-project#10761) * [Remote Store] Fix relocation failure due to transport receive timeout Signed-off-by: Ashish Singh <[email protected]> * Fix existing extended shardIdle for remote backed shards Signed-off-by: Ashish Singh <[email protected]> * Incorporate PR review comments Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Oct 22, 2023
opensearch-project#10761) * [Remote Store] Fix relocation failure due to transport receive timeout Signed-off-by: Ashish Singh <[email protected]> * Fix existing extended shardIdle for remote backed shards Signed-off-by: Ashish Singh <[email protected]> * Incorporate PR review comments Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]>
gbbafna
pushed a commit
that referenced
this pull request
Oct 22, 2023
#10761) (#10788) * [Remote Store] Fix relocation failure due to transport receive timeout * Fix existing extended shardIdle for remote backed shards * Incorporate PR review comments --------- (cherry picked from commit a1fde65) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Oct 23, 2023
opensearch-project#10761) * [Remote Store] Fix relocation failure due to transport receive timeout Signed-off-by: Ashish Singh <[email protected]> * Fix existing extended shardIdle for remote backed shards Signed-off-by: Ashish Singh <[email protected]> * Incorporate PR review comments Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
opensearch-project#10761) * [Remote Store] Fix relocation failure due to transport receive timeout Signed-off-by: Ashish Singh <[email protected]> * Fix existing extended shardIdle for remote backed shards Signed-off-by: Ashish Singh <[email protected]> * Incorporate PR review comments Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Backport to 2.x branch
bug
Something isn't working
skip-changelog
Storage:Durability
Issues and PRs related to the durability framework
v2.12.0
Issues and PRs related to version 2.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves Peer Recovery failure that can happen due to receive timeout exceptions during prepare translog phase of peer recovery. This type of failure can be prominent in zero replica remote store backed indexes. However this can also happen during slow remote interactions. This PR fixes the problem handles both kind of issues.
This PR handles the following cases -
indices.recovery.internal_action_long_timeout
index setting. This, by default, is 30 mins.Related Issues
Resolves #10727
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.