-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Fix Flaky test SegmentReplicationRelocationIT.testPrimaryRelocation #10701
[Segment Replication] Fix Flaky test SegmentReplicationRelocationIT.testPrimaryRelocation #10701
Conversation
Signed-off-by: Rishikesh1159 <[email protected]>
@Poojita-Raj I wasn't able to reproduce the failure mentioned here. I am assuming failure was related to specific PR but let me check all occurances of this flaky test and see the failure. |
Gradle Check (Jenkins) Run Completed with:
|
Lets add testlogging as well incase it fails again we have more visibility. |
server/src/main/java/org/opensearch/indices/replication/SegmentReplicationSourceHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10701 +/- ##
============================================
- Coverage 71.20% 71.15% -0.05%
+ Complexity 58630 58623 -7
============================================
Files 4859 4859
Lines 276305 276300 -5
Branches 40194 40193 -1
============================================
- Hits 196745 196605 -140
- Misses 63178 63306 +128
- Partials 16382 16389 +7
|
...ernalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationRelocationIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
…estPrimaryRelocation (#10701) * Add primary mode check before assserting on primary mode. Signed-off-by: Rishikesh1159 <[email protected]> * remove unnecessary shardRouting check. Signed-off-by: Rishikesh1159 <[email protected]> * Add test logging. Signed-off-by: Rishikesh1159 <[email protected]> * Addressing comments on PR. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit 1e9ec52) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…estPrimaryRelocation (opensearch-project#10701) * Add primary mode check before assserting on primary mode. Signed-off-by: Rishikesh1159 <[email protected]> * remove unnecessary shardRouting check. Signed-off-by: Rishikesh1159 <[email protected]> * Add test logging. Signed-off-by: Rishikesh1159 <[email protected]> * Addressing comments on PR. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]>
…estPrimaryRelocation (#10701) (#10805) * Add primary mode check before assserting on primary mode. * remove unnecessary shardRouting check. * Add test logging. * Addressing comments on PR. --------- (cherry picked from commit 1e9ec52) Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…estPrimaryRelocation (opensearch-project#10701) * Add primary mode check before assserting on primary mode. Signed-off-by: Rishikesh1159 <[email protected]> * remove unnecessary shardRouting check. Signed-off-by: Rishikesh1159 <[email protected]> * Add test logging. Signed-off-by: Rishikesh1159 <[email protected]> * Addressing comments on PR. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR fixes flaky test SegmentReplicationRelocationIT.testPrimaryRelocation by removing unnecessary shardRouting check
Related Issues
Resolves #10029
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.