Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Fix Flaky test SegmentReplicationRelocationIT.testPrimaryRelocation #10701

Merged
merged 9 commits into from
Oct 20, 2023

Conversation

Rishikesh1159
Copy link
Member

@Rishikesh1159 Rishikesh1159 commented Oct 18, 2023

Description

This PR fixes flaky test SegmentReplicationRelocationIT.testPrimaryRelocation by removing unnecessary shardRouting check

Related Issues

Resolves #10029

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. bug Something isn't working flaky-test Random test failure that succeeds on second run Indexing Indexing, Bulk Indexing and anything related to indexing Indexing:Replication Issues and PRs related to core replication framework eg segrep labels Oct 18, 2023
@Rishikesh1159
Copy link
Member Author

Hey Rishi, this change seems to fix the sendFiles problem in the issue description. How does it fix the corruption issue mentioned here: #10029 (comment)

@Poojita-Raj I wasn't able to reproduce the failure mentioned here. I am assuming failure was related to specific PR but let me check all occurances of this flaky test and see the failure.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member

mch2 commented Oct 19, 2023

Hey Rishi, this change seems to fix the sendFiles problem in the issue description. How does it fix the corruption issue mentioned here: #10029 (comment)

@Poojita-Raj I wasn't able to reproduce the failure mentioned here. I am assuming failure was related to specific PR but let me check all occurances of this flaky test and see the failure.

Lets add testlogging as well incase it fails again we have more visibility.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testTrackerData

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #10701 (3575549) into main (a1fde65) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10701      +/-   ##
============================================
- Coverage     71.20%   71.15%   -0.05%     
+ Complexity    58630    58623       -7     
============================================
  Files          4859     4859              
  Lines        276305   276300       -5     
  Branches      40194    40193       -1     
============================================
- Hits         196745   196605     -140     
- Misses        63178    63306     +128     
- Partials      16382    16389       +7     
Files Coverage Δ
...s/replication/SegmentReplicationSourceHandler.java 96.00% <ø> (+3.50%) ⬆️

... and 500 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Rishikesh1159 Rishikesh1159 changed the title [Segment Replication] Fix Flaky test SegmentReplicationRelocationIT.testPrimaryRelocation by adding primary mode check [Segment Replication] Fix Flaky test SegmentReplicationRelocationIT.testPrimaryRelocation Oct 20, 2023
@Rishikesh1159 Rishikesh1159 added the backport 2.x Backport to 2.x branch label Oct 20, 2023
@Rishikesh1159 Rishikesh1159 merged commit 1e9ec52 into opensearch-project:main Oct 20, 2023
23 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 20, 2023
…estPrimaryRelocation (#10701)

* Add primary mode check before assserting on primary mode.

Signed-off-by: Rishikesh1159 <[email protected]>

* remove unnecessary shardRouting check.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add test logging.

Signed-off-by: Rishikesh1159 <[email protected]>

* Addressing comments on PR.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
(cherry picked from commit 1e9ec52)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
…estPrimaryRelocation (opensearch-project#10701)

* Add primary mode check before assserting on primary mode.

Signed-off-by: Rishikesh1159 <[email protected]>

* remove unnecessary shardRouting check.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add test logging.

Signed-off-by: Rishikesh1159 <[email protected]>

* Addressing comments on PR.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
Rishikesh1159 pushed a commit that referenced this pull request Oct 26, 2023
…estPrimaryRelocation (#10701) (#10805)

* Add primary mode check before assserting on primary mode.



* remove unnecessary shardRouting check.



* Add test logging.



* Addressing comments on PR.



---------


(cherry picked from commit 1e9ec52)

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…estPrimaryRelocation (opensearch-project#10701)

* Add primary mode check before assserting on primary mode.

Signed-off-by: Rishikesh1159 <[email protected]>

* remove unnecessary shardRouting check.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add test logging.

Signed-off-by: Rishikesh1159 <[email protected]>

* Addressing comments on PR.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run Indexing:Replication Issues and PRs related to core replication framework eg segrep Indexing Indexing, Bulk Indexing and anything related to indexing skip-changelog >test-failure Test failure from CI, local build, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SegmentReplicationRelocationIT.testPrimaryRelocation flaky test failure
4 participants