Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds util to compare Metadata for remote state #10661

Merged
merged 10 commits into from
Oct 22, 2023

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented Oct 17, 2023

Description

  • Adds a new util to compare Metadata content(excluding IndexMetadata) for entities uploaded to remote store as part of remote state.
  • When cluster uuid trimming logic runs, it would use this util to compare metadata b/w two different UUIDs

Related Issues

Resolves #10662

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label Oct 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Compatibility status:

Checks if related components are compatible with change 91a3643

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #10661 (91a3643) into main (5093cc7) will increase coverage by 0.12%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##               main   #10661      +/-   ##
============================================
+ Coverage     71.16%   71.29%   +0.12%     
- Complexity    58587    58655      +68     
============================================
  Files          4859     4859              
  Lines        276267   276272       +5     
  Branches      40189    40189              
============================================
+ Hits         196610   196961     +351     
+ Misses        63246    62872     -374     
- Partials      16411    16439      +28     
Files Coverage Δ
...java/org/opensearch/cluster/metadata/Metadata.java 89.54% <83.33%> (+0.26%) ⬆️
...arch/gateway/remote/RemoteClusterStateService.java 69.78% <83.33%> (+0.04%) ⬆️

... and 477 files with indirect coverage changes

@shwetathareja
Copy link
Member

Add UTs

@linuxpi linuxpi force-pushed the remote-metadata-equals branch from d55b641 to fbc0eee Compare October 19, 2023 05:26
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: bansvaru <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: bansvaru <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi
Copy link
Collaborator Author

linuxpi commented Oct 20, 2023

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@shwetathareja shwetathareja merged commit 79c6e32 into opensearch-project:main Oct 22, 2023
18 of 19 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Oct 22, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 22, 2023
* Adds util to compare Metadata for remote state durng restore flow when identifying if 2 clusterUUIDs have same cluster state

Signed-off-by: bansvaru <[email protected]>
(cherry picked from commit 79c6e32)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@linuxpi linuxpi deleted the remote-metadata-equals branch October 22, 2023 06:58
shwetathareja pushed a commit that referenced this pull request Oct 22, 2023
* Adds util to compare Metadata for remote state durng restore flow when identifying if 2 clusterUUIDs have same cluster state

(cherry picked from commit 79c6e32)

Signed-off-by: bansvaru <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
)

* Adds util to compare Metadata for remote state durng restore flow when identifying if 2 clusterUUIDs have same cluster state

Signed-off-by: bansvaru <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request skip-changelog
Projects
None yet
2 participants