-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Unmute Test SegmentReplicationTargetServiceTests.testShardAlreadyReplicating #10660
[Segment Replication] Unmute Test SegmentReplicationTargetServiceTests.testShardAlreadyReplicating #10660
Conversation
Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishikesh1159 <[email protected]>
Compatibility status:Checks if related components are compatible with change c7aa4f6 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10660 +/- ##
=========================================
Coverage 71.15% 71.16%
+ Complexity 58497 58472 -25
=========================================
Files 4853 4853
Lines 275758 275758
Branches 40134 40134
=========================================
+ Hits 196215 196240 +25
+ Misses 63162 63111 -51
- Partials 16381 16407 +26 |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please look at the flaky gradle checks in this PR and link the issues for those?
@Rishikesh1159 I can't tell from #8928 where this was fixed? |
...r/src/test/java/org/opensearch/indices/replication/SegmentReplicationTargetServiceTests.java
Show resolved
Hide resolved
Signed-off-by: Rishikesh1159 <[email protected]>
Failure reason: ':server:spotlessJavaCheck' |
Flaky test: -> org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod -> org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod -> org.opensearch.index.shard.RemoteIndexShardTests.testRepicaCleansUpOldCommitsWhenReceivingNew - #10303 |
I am not able to reproduce the test failure. I tried running entire test suite class but still not able to reproduce. This flaky test might be fixed from some changes happened in last 2 months. I am adding trace logging with test, so next time if we see this test failing we can get more info from logs. |
Gradle Check (Jenkins) Run Completed with:
|
known flaky test: #5176 |
…s.testShardAlreadyReplicating (#10660) * Remove Awaits fix. Signed-off-by: Rishikesh1159 <[email protected]> * apply spotlesscheck. Signed-off-by: Rishikesh1159 <[email protected]> * add test logging. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit e942483) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…s.testShardAlreadyReplicating (opensearch-project#10660) * Remove Awaits fix. Signed-off-by: Rishikesh1159 <[email protected]> * apply spotlesscheck. Signed-off-by: Rishikesh1159 <[email protected]> * add test logging. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]>
…s.testShardAlreadyReplicating (opensearch-project#10660) * Remove Awaits fix. Signed-off-by: Rishikesh1159 <[email protected]> * apply spotlesscheck. Signed-off-by: Rishikesh1159 <[email protected]> * add test logging. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]>
…s.testShardAlreadyReplicating (opensearch-project#10660) * Remove Awaits fix. Signed-off-by: Rishikesh1159 <[email protected]> * apply spotlesscheck. Signed-off-by: Rishikesh1159 <[email protected]> * add test logging. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR unmutes Test
SegmentReplicationTargetServiceTests.testShardAlreadyReplicating
Related Issues
Resolves #8928
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.