Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download reporting for segment replication #10644

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

kotwanikunal
Copy link
Member

@kotwanikunal kotwanikunal commented Oct 16, 2023

Description

Related Issues

Resolves #10515

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Compatibility status:

Checks if related components are compatible with change 0370a4e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #10644 (0b698c7) into main (7b62e2f) will decrease coverage by 0.08%.
Report is 2 commits behind head on main.
The diff coverage is 77.63%.

@@             Coverage Diff              @@
##               main   #10644      +/-   ##
============================================
- Coverage     71.26%   71.19%   -0.08%     
+ Complexity    58561    58556       -5     
============================================
  Files          4853     4853              
  Lines        275764   275816      +52     
  Branches      40135    40139       +4     
============================================
- Hits         196535   196361     -174     
- Misses        62800    63065     +265     
+ Partials      16429    16390      -39     
Files Coverage Δ
...rg/opensearch/telemetry/tracing/DefaultTracer.java 100.00% <100.00%> (ø)
.../opensearch/telemetry/tracing/noop/NoopTracer.java 87.50% <100.00%> (+1.78%) ⬆️
...search/telemetry/metrics/OTelMetricsTelemetry.java 100.00% <100.00%> (ø)
...rg/opensearch/telemetry/tracing/OTelTelemetry.java 100.00% <100.00%> (ø)
...search/telemetry/tracing/OTelTracingTelemetry.java 95.83% <100.00%> (+0.37%) ⬆️
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <100.00%> (ø)
...ces/replication/PrimaryShardReplicationSource.java 96.00% <ø> (ø)
...ices/replication/RemoteStoreReplicationSource.java 91.07% <100.00%> (+0.16%) ⬆️
...va/org/opensearch/telemetry/TelemetrySettings.java 90.90% <100.00%> (+3.40%) ⬆️
...rg/opensearch/telemetry/tracing/WrappedTracer.java 78.57% <100.00%> (+1.64%) ⬆️
... and 9 more

... and 485 files with indirect coverage changes

@kotwanikunal kotwanikunal merged commit c001417 into opensearch-project:main Oct 18, 2023
16 checks passed
@kotwanikunal kotwanikunal added the backport 2.x Backport to 2.x branch label Oct 18, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2023
Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit c001417)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Oct 18, 2023
Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit c001417)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 19, 2023
kotwanikunal pushed a commit that referenced this pull request Oct 19, 2023
Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit c001417)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Oct 19, 2023
(cherry picked from commit c001417)

Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] _cat/segment_replication returns no data
2 participants