-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix download reporting for segment replication #10644
Conversation
Compatibility status:Checks if related components are compatible with change 0370a4e Incompatible componentsIncompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git] |
Gradle Check (Jenkins) Run Completed with:
|
a60f089
to
2b7b0eb
Compare
server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTarget.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
2b7b0eb
to
2f7c034
Compare
Gradle Check (Jenkins) Run Completed with:
|
2f7c034
to
9de41cb
Compare
Gradle Check (Jenkins) Run Completed with:
|
9de41cb
to
45fd05a
Compare
Gradle Check (Jenkins) Run Completed with:
|
45fd05a
to
0370a4e
Compare
Signed-off-by: Kunal Kotwani <[email protected]>
0370a4e
to
0b698c7
Compare
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/indices/replication/SegmentReplicationSource.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/replication/RemoteStoreReplicationSource.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10644 +/- ##
============================================
- Coverage 71.26% 71.19% -0.08%
+ Complexity 58561 58556 -5
============================================
Files 4853 4853
Lines 275764 275816 +52
Branches 40135 40139 +4
============================================
- Hits 196535 196361 -174
- Misses 62800 63065 +265
+ Partials 16429 16390 -39
|
Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit c001417) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit c001417) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) Signed-off-by: Kunal Kotwani <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit c001417) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c001417) Signed-off-by: Kunal Kotwani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) Signed-off-by: Kunal Kotwani <[email protected]>
) Signed-off-by: Kunal Kotwani <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
_cat/segment_replication
returns the replica results when the replication event completes successfully which is recorded here - https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java#L520-L522Related Issues
Resolves #10515
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.