-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an optional DEVELOPER_GUIDE tool #10132
base: main
Are you sure you want to change the base?
Conversation
…ation. Signed-off-by: David Tippett <[email protected]>
Compatibility status:Checks if related components are compatible with change 89a9011 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/security-analytics.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10132 +/- ##
============================================
+ Coverage 71.02% 71.10% +0.08%
- Complexity 58078 58088 +10
============================================
Files 4825 4825
Lines 274032 274101 +69
Branches 39930 39946 +16
============================================
+ Hits 194628 194906 +278
+ Misses 63067 62802 -265
- Partials 16337 16393 +56 ☔ View full report in Codecov by Sentry. |
@@ -74,6 +74,35 @@ Fork [opensearch-project/OpenSearch](https://github.com/opensearch-project/OpenS | |||
|
|||
### Install Prerequisites | |||
|
|||
|
|||
### [Optional] sdkman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to TOC please.
I think you can make this section "SDKman" to make it consistent capitalization-wise and just say "We recommend a tool such as SDKman to manage JDKs".
@@ -74,6 +74,35 @@ Fork [opensearch-project/OpenSearch](https://github.com/opensearch-project/OpenS | |||
|
|||
### Install Prerequisites | |||
|
|||
|
|||
### [Optional] sdkman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to change this to heading 4 (i.e. ####
instead of ###
)
We should also change the PR title to be imperative style (i.e. |
This PR is stalled because it has been open for 30 days with no activity. |
Hi @dtaivpp, Is this being worked upon? Feel free to reach out to maintainers for further reviews. |
@ticheng-aws sorry for the delay I’ll get these changes in. |
This PR is stalled because it has been open for 30 days with no activity. |
@dtaivpp Checking again if you plan to clean this up ? |
This PR is stalled because it has been open for 30 days with no activity. |
This PR is stalled because it has been open for 30 days with no activity. |
@dtaivpp Are you still working on this? |
Description
Added optional tool SDKMan in
DEVELOPER_GUIDE
to simplify JDK environment installation and sourcing.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.