-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to support IP field in star tree indexing #16641
Changes to support IP field in star tree indexing #16641
Conversation
❌ Gradle check result for 5ed38f0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
5ed38f0
to
15a58b4
Compare
15a58b4
to
217db78
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16641 +/- ##
============================================
- Coverage 72.21% 72.14% -0.07%
+ Complexity 65335 65276 -59
============================================
Files 5318 5319 +1
Lines 304081 304115 +34
Branches 43995 43999 +4
============================================
- Hits 219578 219405 -173
- Misses 66541 66679 +138
- Partials 17962 18031 +69 ☔ View full report in Codecov by Sentry. |
...main/java/org/opensearch/index/codec/composite/composite912/Composite912DocValuesWriter.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/DimensionFactory.java
Show resolved
Hide resolved
ab950b2
to
3edb512
Compare
❌ Gradle check result for 3edb512: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3edb512
to
dbde796
Compare
❌ Gradle check result for dbde796: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: bharath-techie <[email protected]>
dbde796
to
bc2e847
Compare
❌ Gradle check result for bc2e847: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: bharath-techie <[email protected]>
bc2e847
to
7a81d2f
Compare
❕ Gradle check result for 7a81d2f: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❕ Gradle check result for bf12791: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
server/src/main/java/org/opensearch/index/compositeindex/datacube/DimensionFactory.java
Show resolved
Hide resolved
Tests are added as part of integ tests as well. Codecov is failing as it does not include coverage from integ tests. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16641-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e6d71d290e56e93920f8b8efa5ddbf885699607e
# Push it to GitHub
git push --set-upstream origin backport/backport-16641-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Description
The changes include support for IP field as part of star tree index as part of dimensions specifically.
Related Issues
Resolves #16642
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.