Add test for default value of false

Signed-off-by: Craig Perkins <[email protected]>
opensearch-project · Mar 22, 2024 · ea21ee8 · ea21ee8
1 parent 86769ec
commit ea21ee8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/server/src/main/java/org/opensearch/common/util/FeatureFlags.java b/server/src/main/java/org/opensearch/common/util/FeatureFlags.java
@@ -102,7 +102,7 @@ public class FeatureFlags {
         .put(DATETIME_FORMATTER_CACHING_SETTING.getKey(), DATETIME_FORMATTER_CACHING_SETTING.getDefault(Settings.EMPTY))
         .put(WRITEABLE_REMOTE_INDEX_SETTING.getKey(), WRITEABLE_REMOTE_INDEX_SETTING.getDefault(Settings.EMPTY))
         .put(PLUGGABLE_CACHE_SETTING.getKey(), PLUGGABLE_CACHE_SETTING.getDefault(Settings.EMPTY))
-        .build();;
+        .build();
 
     /**
      * This method is responsible to map settings from opensearch.yml to local stored

diff --git a/server/src/test/java/org/opensearch/common/util/FeatureFlagTests.java b/server/src/test/java/org/opensearch/common/util/FeatureFlagTests.java
@@ -12,6 +12,7 @@
 import org.opensearch.test.OpenSearchTestCase;
 
 import static org.opensearch.common.util.FeatureFlags.DATETIME_FORMATTER_CACHING;
+import static org.opensearch.common.util.FeatureFlags.IDENTITY;
 
 public class FeatureFlagTests extends OpenSearchTestCase {
 
@@ -41,4 +42,10 @@ public void testBooleanFeatureFlagWithDefaultSetToTrue() {
         assertNotNull(testFlag);
         assertTrue(FeatureFlags.isEnabled(testFlag));
     }
+
+    public void testBooleanFeatureFlagWithDefaultSetToFalse() {
+        final String testFlag = IDENTITY;
+        assertNotNull(testFlag);
+        assertFalse(FeatureFlags.isEnabled(testFlag));
+    }
 }