Skip to content

Commit

Permalink
more PR comments
Browse files Browse the repository at this point in the history
Signed-off-by: Gaurav Bafna <[email protected]>
  • Loading branch information
gbbafna authored and ashking94 committed Oct 23, 2023
1 parent 5b0c6fc commit c411a25
Showing 1 changed file with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,6 @@ private RemoteFsTranslog create(Path path) throws IOException {
return create(path, createRepository(), translogUUID, 0);
}

private RemoteFsTranslog create(Path path, int extraGenToKeep) throws IOException {
return create(path, extraGenToKeep);
}

private RemoteFsTranslog create(Path path, BlobStoreRepository repository, String translogUUID, int extraGenToKeep) throws IOException {
this.repository = repository;
globalCheckpoint = new AtomicLong(SequenceNumbers.NO_OPS_PERFORMED);
Expand Down Expand Up @@ -739,6 +735,7 @@ public void testSimpleOperationsUpload() throws Exception {
// this should now trim as tlog-2 files from remote, but not tlog-3 and tlog-4
addToTranslogAndListAndUpload(translog, ops, new Translog.Index("2", 2, primaryTerm.get(), new byte[] { 1 }));
assertEquals(2, translog.stats().estimatedNumberOfOperations());
assertBusy(() -> assertTrue(translog.isRemoteGenerationDeletionPermitsAvailable()));

translog.setMinSeqNoToKeep(2);
// this should now trim as tlog-2 files from remote, but not tlog-3 and tlog-4
Expand Down

0 comments on commit c411a25

Please sign in to comment.