Fix passing wrong parameter when calling newConfigurationException() …

…in DotExpanderProcessor (#10737) (#11013) * Fix passing wrong parameter when calling newConfigurationException() in DotExpanderProcessor Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit 9d85e56) Signed-off-by: Gao Binlong <[email protected]>
opensearch-project · Nov 20, 2023 · a755fe3 · a755fe3
1 parent a27c35d
commit a755fe3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -64,6 +64,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ### Fixed
 - Fix class_cast_exception when passing int to _version and other metadata fields in ingest simulate API ([#10101](https://github.com/opensearch-project/OpenSearch/pull/10101))
+- Fix passing wrong parameter when calling newConfigurationException() in DotExpanderProcessor ([#10737](https://github.com/opensearch-project/OpenSearch/pull/10737))
 - Fix per request latency last phase not tracked ([#10934](https://github.com/opensearch-project/OpenSearch/pull/10934))
 - Adding version condition while adding geoshape doc values to the index, to ensure backward compatibility.([#11095](https://github.com/opensearch-project/OpenSearch/pull/11095))
 - Fix SuggestSearch.testSkipDuplicates by forcing refresh when indexing its test documents ([#11068](https://github.com/opensearch-project/OpenSearch/pull/11068))

diff --git a/modules/ingest-common/src/main/java/org/opensearch/ingest/common/DotExpanderProcessor.java b/modules/ingest-common/src/main/java/org/opensearch/ingest/common/DotExpanderProcessor.java
@@ -118,25 +118,15 @@ public Processor create(
         ) throws Exception {
             String field = ConfigurationUtils.readStringProperty(TYPE, tag, config, "field");
             if (field.contains(".") == false) {
-                throw ConfigurationUtils.newConfigurationException(
-                    ConfigurationUtils.TAG_KEY,
-                    tag,
-                    "field",
-                    "field does not contain a dot"
-                );
+                throw ConfigurationUtils.newConfigurationException(TYPE, tag, "field", "field does not contain a dot");
             }
             if (field.indexOf('.') == 0 || field.lastIndexOf('.') == field.length() - 1) {
-                throw ConfigurationUtils.newConfigurationException(
-                    ConfigurationUtils.TAG_KEY,
-                    tag,
-                    "field",
-                    "Field can't start or end with a dot"
-                );
+                throw ConfigurationUtils.newConfigurationException(TYPE, tag, "field", "Field can't start or end with a dot");
             }
             int firstIndex = -1;
             for (int index = field.indexOf('.'); index != -1; index = field.indexOf('.', index + 1)) {
                 if (index - firstIndex == 1) {
-                    throw ConfigurationUtils.newConfigurationException(ConfigurationUtils.TAG_KEY, tag, "field", "No space between dots");
+                    throw ConfigurationUtils.newConfigurationException(TYPE, tag, "field", "No space between dots");
                 }
                 firstIndex = index;
             }