Fix IpRangeAggregatorTests

Rewrote a for-loop in BinaryRangeAggregator to be less confusing. As a side-effect, it fixed the test. Signed-off-by: Michael Froh <[email protected]>
opensearch-project · Dec 19, 2024 · 7ca821a · 7ca821a
1 parent 8861111
commit 7ca821a
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/.../src/main/java/org/opensearch/search/aggregations/bucket/range/BinaryRangeAggregator.java b/.../src/main/java/org/opensearch/search/aggregations/bucket/range/BinaryRangeAggregator.java
@@ -202,9 +202,11 @@ abstract static class SortedSetRangeLeafCollector extends LeafBucketCollectorBas
         public void collect(int doc, long bucket) throws IOException {
             if (values.advanceExact(doc)) {
                 int lo = 0;
-                int count = 0;
-                for (long ord = values.nextOrd(); ord != SortedSetDocValues.NO_MORE_DOCS && count < values.docValueCount(); ord = values
-                    .nextOrd(), ++count) {
+                for (int i = 0; i < values.docValueCount(); i++) {
+                    long ord = values.nextOrd();
+                    if (ord == SortedSetDocValues.NO_MORE_DOCS) {
+                        break;
+                    }
                     lo = collect(doc, ord, bucket, lo);
                 }
             }