Address PR comments

Signed-off-by: Ketan Verma <[email protected]>

libs/common/src/main/java/org/opensearch/common/round/BidirectionalLinearSearcher.java

@@ -27,7 +27,7 @@ class BidirectionalLinearSearcher implements Roundable {
     private final long[] ascending;
     private final long[] descending;
 
-    public BidirectionalLinearSearcher(long[] values, int size) {
+    BidirectionalLinearSearcher(long[] values, int size) {
         assert size > 0 : "at least one value must be present";
 
         int len = (size + 1) >>> 1; // rounded-up to handle odd number of values

libs/common/src/main/java/org/opensearch/common/round/BinarySearcher.java

@@ -22,7 +22,7 @@ class BinarySearcher implements Roundable {
     private final long[] values;
     private final int size;
 
-    public BinarySearcher(long[] values, int size) {
+    BinarySearcher(long[] values, int size) {
         assert size > 0 : "at least one value must be present";
 
         this.values = values;

libs/common/src/main/java/org/opensearch/common/round/RoundableFactory.java

@@ -8,10 +8,15 @@
 
 package org.opensearch.common.round;
 
+import org.opensearch.common.annotation.InternalApi;
+
 /**
  * Factory class to create and return the fastest implementation of {@link Roundable}.
+ *
+ * @opensearch.internal
  */
-public class RoundableFactory {
+@InternalApi
+public final class RoundableFactory {
     /**
      * The maximum limit up to which linear search is used, otherwise binary search is used.
      * This is because linear search is much faster on small arrays.

server/src/main/java/org/opensearch/common/Rounding.java

@@ -444,7 +444,7 @@ protected Prepared maybeUseArray(long minUtcMillis, long maxUtcMillis, int max)
                 values = ArrayUtil.grow(values, i + 1);
                 values[i++] = rounded;
             }
-            return new ArrayRounding(values, i, this);
+            return new ArrayRounding(RoundableFactory.create(values, i), this);
         }
     }
 
@@ -456,8 +456,8 @@ private static class ArrayRounding implements Prepared {
         private final Roundable roundable;
         private final Prepared delegate;
 
-        public ArrayRounding(long[] values, int size, Prepared delegate) {
-            this.roundable = RoundableFactory.create(values, size);
+        public ArrayRounding(Roundable roundable, Prepared delegate) {
+            this.roundable = roundable;
             this.delegate = delegate;
         }