Finally figured out the generics (or lack thereof)

Signed-off-by: Daniel Widdis <[email protected]>
opensearch-project · Mar 17, 2023 · 3829f15 · 3829f15
1 parent 7893511
commit 3829f15
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/server/src/main/java/org/opensearch/action/ActionModule.java b/server/src/main/java/org/opensearch/action/ActionModule.java
@@ -976,8 +976,7 @@ public ActionFilters getActionFilters() {
         return actionFilters;
     }
 
-    @SuppressWarnings("unchecked")
-    public DynamicActionRegistry<? extends ActionRequest, ? extends ActionResponse> getDynamicActionRegistry() {
+    public DynamicActionRegistry getDynamicActionRegistry() {
         return dynamicActionRegistry;
     }
 
@@ -992,7 +991,7 @@ public RestController getRestController() {
      *
      * @opensearch.internal
      */
-    public static class DynamicActionRegistry<Request extends ActionRequest, Response extends ActionResponse> {
+    public static class DynamicActionRegistry {
         // the immutable map of injected transport actions
         private Map<ActionType, TransportAction> actions = Collections.emptyMap();
         // the dynamic map which can be updated over time
@@ -1058,9 +1057,9 @@ public void unregisterExtensionAction(ExtensionAction extensionAction) {
          * @return the corresponding {@link TransportAction} if it is registered, null otherwise.
          */
         @SuppressWarnings("unchecked")
-        public TransportAction<Request, Response> get(ActionType<?> action) {
+        public TransportAction<? extends ActionRequest, ? extends ActionResponse> get(ActionType<?> action) {
             if (action instanceof ExtensionAction) {
-                return (TransportAction<Request, Response>) registry.get((ExtensionAction) action);
+                return registry.get((ExtensionAction) action);
             }
             return actions.get(action);
         }

diff --git a/server/src/main/java/org/opensearch/client/node/NodeClient.java b/server/src/main/java/org/opensearch/client/node/NodeClient.java
@@ -146,8 +146,7 @@ private <Request extends ActionRequest, Response extends ActionResponse> Transpo
         if (actionRegistry == null) {
             throw new IllegalStateException("NodeClient has not been initialized");
         }
-        // Get from action map if it exists
-        TransportAction<Request, Response> transportAction = actionRegistry.get(action);
+        TransportAction<Request, Response> transportAction = (TransportAction<Request, Response>) actionRegistry.get(action);
         if (transportAction == null) {
             throw new IllegalStateException("failed to find action [" + action + "] to execute");
         }

diff --git a/server/src/main/java/org/opensearch/node/Node.java b/server/src/main/java/org/opensearch/node/Node.java
@@ -59,8 +59,6 @@
 import org.opensearch.Version;
 import org.opensearch.action.ActionModule;
 import org.opensearch.action.ActionModule.DynamicActionRegistry;
-import org.opensearch.action.ActionRequest;
-import org.opensearch.action.ActionResponse;
 import org.opensearch.action.ActionType;
 import org.opensearch.action.admin.cluster.snapshots.status.TransportNodesSnapshotsStatus;
 import org.opensearch.action.search.SearchExecutionStatsCollector;
@@ -1115,8 +1113,7 @@ protected Node(
             resourcesToClose.addAll(pluginLifecycleComponents);
             resourcesToClose.add(injector.getInstance(PeerRecoverySourceService.class));
             this.pluginLifecycleComponents = Collections.unmodifiableList(pluginLifecycleComponents);
-            DynamicActionRegistry<? extends ActionRequest, ? extends ActionResponse> dynamicActionRegistry = actionModule
-                .getDynamicActionRegistry();
+            DynamicActionRegistry dynamicActionRegistry = actionModule.getDynamicActionRegistry();
             dynamicActionRegistry.initialize(injector.getInstance(new Key<Map<ActionType, TransportAction>>() {
             }), actionModule.getActionFilters(), transportService, extensionsManager);
             client.initialize(