address comments

Signed-off-by: Kiran Prakash <[email protected]>
opensearch-project · Apr 12, 2024 · 31d9c54 · 31d9c54
1 parent 4c69187
commit 31d9c54
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -48,7 +48,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Fix UOE While building Exists query for nested search_as_you_type field ([#12048](https://github.com/opensearch-project/OpenSearch/pull/12048))
 - Client with Java 8 runtime and Apache HttpClient 5 Transport fails with java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer ([#13100](https://github.com/opensearch-project/opensearch-java/pull/13100))
 - Fix implement mark() and markSupported() in class FilterStreamInput ([#13098](https://github.com/opensearch-project/OpenSearch/pull/13098))
-- Fix IndicesRequestCache Stale calculation to be accurate. ([#13070](https://github.com/opensearch-project/OpenSearch/pull/13070)]
+- Fix IndicesRequestCache Stale calculation ([#13070](https://github.com/opensearch-project/OpenSearch/pull/13070)]
 
 ### Security
 

diff --git a/server/src/main/java/org/opensearch/indices/IndicesRequestCache.java b/server/src/main/java/org/opensearch/indices/IndicesRequestCache.java
@@ -545,7 +545,7 @@ private void updateStaleCountOnEntryRemoval(CleanupKey cleanupKey, RemovalNotifi
                     // but do not decrement the staleKeysCount
                     Integer count = readerCacheKeyMap.get(cleanupKey.readerCacheKeyId);
                     // this should never be null
-                    assert (count != null);
+                    assert (count != null && count >= 0);
                     // Reduce the count by 1
                     int newCount = count - 1;
                     if (newCount <= 0) {