Stash

Signed-off-by: Finn Carroll <[email protected]>
opensearch-project · Sep 12, 2024 · 1dc0ad7 · 1dc0ad7
1 parent 30a7516
commit 1dc0ad7
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/server/src/test/java/org/opensearch/search/ProtobufSearchHitsHelperSerializationTests.java b/server/src/test/java/org/opensearch/search/ProtobufSearchHitsHelperSerializationTests.java
@@ -50,27 +50,35 @@ public void testProtoExplanationSerDe() {
         ExplanationProto proto = explanationToProto(orig);
         Explanation cpy = explanationFromProto(proto);
         assertEquals(orig, cpy);
+        assertEquals(orig.hashCode(), cpy.hashCode());
+        assertNotSame(orig, cpy);
     }
 
     public void testProtoDocumentFieldSerDe() {
         DocumentField orig = randomDocumentField(randomFrom(XContentType.values()), randomBoolean(), fieldName -> false).v1();
         DocumentFieldProto proto = documentFieldToProto(orig);
         DocumentField cpy = documentFieldFromProto(proto);
         assertEquals(orig, cpy);
+        assertEquals(orig.hashCode(), cpy.hashCode());
+        assertNotSame(orig, cpy);
     }
 
     public void testProtoHighlightFieldSerDe() {
         HighlightField orig = HighlightFieldTests.createTestItem();
         HighlightFieldProto proto = highlightFieldToProto(orig);
         HighlightField cpy = highlightFieldFromProto(proto);
         assertEquals(orig, cpy);
+        assertEquals(orig.hashCode(), cpy.hashCode());
+        assertNotSame(orig, cpy);
     }
 
     public void testProtoSearchSortValuesSerDe() {
         SearchSortValues orig = SearchSortValuesTests.createTestItem(randomFrom(XContentType.values()), true);
         SearchSortValuesProto proto = searchSortValuesToProto(orig);
         SearchSortValues cpy = searchSortValuesFromProto(proto);
         assertEquals(orig, cpy);
+        assertEquals(orig.hashCode(), cpy.hashCode());
+        assertNotSame(orig, cpy);
     }
 
     public void testProtoSearchShardTargetSerDe() {
@@ -86,19 +94,25 @@ public void testProtoSearchShardTargetSerDe() {
         SearchShardTargetProto proto = searchShardTargetToProto(orig);
         SearchShardTarget cpy = searchShardTargetFromProto(proto);
         assertEquals(orig, cpy);
+        assertEquals(orig.hashCode(), cpy.hashCode());
+        assertNotSame(orig, cpy);
     }
 
     public void testProtoShardIdSerDe() {
         ShardId orig = new ShardId(new Index(randomAlphaOfLengthBetween(5, 10), randomAlphaOfLengthBetween(5, 10)), randomInt());
         ShardIdProto proto = shardIdToProto(orig);
         ShardId cpy = shardIdFromProto(proto);
         assertEquals(orig, cpy);
+        assertEquals(orig.hashCode(), cpy.hashCode());
+        assertNotSame(orig, cpy);
     }
 
     public void testProtoIndexSerDe() {
         Index orig = new Index(randomAlphaOfLengthBetween(5, 10), randomAlphaOfLengthBetween(5, 10));
         IndexProto proto = indexToProto(orig);
         Index cpy = indexFromProto(proto);
         assertEquals(orig, cpy);
+        assertEquals(orig.hashCode(), cpy.hashCode());
+        assertNotSame(orig, cpy);
     }
 }
diff --git a/server/src/test/java/org/opensearch/search/SearchHitsProtobufTests.java b/server/src/test/java/org/opensearch/search/SearchHitsProtobufTests.java
@@ -44,6 +44,27 @@
 
 public class SearchHitsProtobufTests extends AbstractWireSerializingTestCase<SearchHitsProtobuf> {
 
+    public void testTotalHitsProtoSerialization () {
+
+    }
+
+    public void testSortValueProtoSerialization () {
+
+    }
+
+    public void testSortFieldProtoSerialization () {
+
+    }
+
+    public void testTotalHitsProtoSerialization () {
+
+    }
+
+    optional TotalHitsProto total_hits = 5;
+    repeated SortValueProto collapse_values = 4;
+    repeated SortFieldProto sort_fields = 3;
+    repeated SearchHitProto hits = 6;
+
     @Override
     protected Writeable.Reader<SearchHitsProtobuf> instanceReader() {
         return SearchHitsProtobuf::new;