nits

Signed-off-by: Sarthak Aggarwal <[email protected]>
opensearch-project · Jul 17, 2024 · 081f8b8 · 081f8b8
1 parent 7caf5a0
commit 081f8b8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,7 +19,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Print reason why parent task was cancelled ([#14604](https://github.com/opensearch-project/OpenSearch/issues/14604))
 - Add matchesPluginSystemIndexPattern to SystemIndexRegistry ([#14750](https://github.com/opensearch-project/OpenSearch/pull/14750))
 - Add Plugin interface for loading application based configuration templates (([#14659](https://github.com/opensearch-project/OpenSearch/issues/14659)))
-- Star Tree Implementation (OnHeap) ([#14512](https://github.com/opensearch-project/OpenSearch/pull/14512))
 
 ### Dependencies
 - Bump `org.gradle.test-retry` from 1.5.8 to 1.5.9 ([#13442](https://github.com/opensearch-project/OpenSearch/pull/13442))

diff --git a/...va/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java b/...va/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
@@ -628,7 +628,7 @@ private StarTreeDocument createAggregatedDocs(TreeNode node) throws IOException
                 // If no star child exists, aggregate all aggregated documents from non-star children
                 if (node.children.values().size() == 1) {
                     for (TreeNode child : node.children.values()) {
-                        aggregatedStarTreeDocument = createAggregatedDocs(child);
+                        aggregatedStarTreeDocument = reduceStarTreeDocuments(aggregatedStarTreeDocument, createAggregatedDocs(child));
                         node.aggregatedDocId = child.aggregatedDocId;
                     }
                 } else {

diff --git a/...opensearch/index/compositeindex/datacube/startree/builder/OnHeapStarTreeBuilderTests.java b/...opensearch/index/compositeindex/datacube/startree/builder/OnHeapStarTreeBuilderTests.java
@@ -695,6 +695,7 @@ public void test_build_starTreeDataset() throws IOException {
             assertEquals(expectedStarTreeDocument.dimensions[2], resultStarTreeDocument.dimensions[2]);
             assertEquals(expectedStarTreeDocument.metrics[0], resultStarTreeDocument.metrics[0]);
         }
+
     }
 
     @Override
-Original file line number
+Diff line change
@@ Expand Up @@
                 assertEquals(expectedStarTreeDocument.dimensions[2], resultStarTreeDocument.dimensions[2]);
                 assertEquals(expectedStarTreeDocument.metrics[0], resultStarTreeDocument.metrics[0]);
             }
         }
         @Override
@@ Expand Down @@