Fix visualization chart not expanded after legend toggle #9170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the chart was not expanding after hiding the legend. The root cause was that the
VisLegend
component was usingvis.getUiState()
as theuiState
, which was different from theuiState
in theVisualizationChart
component. According to the code in visualization_chart, it was usingthis.props.uiState
. Therefore, changes tovis.legendOpen
were not triggering a re-render inVisualizationChart
.To resolve this issue, I added a
uiState
synchronization logic insrc/plugins/visualizations/public/expressions/visualization_renderer.tsx
. This logic compares thevisState
invis
and callssetState
to ensure that the twouiState
instances are the same. As a result, the chart will be resized correctly.Issues Resolved
#9143
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration