Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [workspace] fix the UI of delete modal in the save objects(assets) page #9132

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport fb9a814 from #8237.

…ge (#8237)

* fix/fix_UI_of_Assets_modal

Signed-off-by: Qxisylolo <[email protected]>

* correct tests

Signed-off-by: Qxisylolo <[email protected]>

* Changeset file for PR #8237 created/updated

* disable button

Signed-off-by: Qxisylolo <[email protected]>

* update test

Signed-off-by: Qxisylolo <[email protected]>

* fix tests

Signed-off-by: Qxisylolo <[email protected]>

* update snapshot

Signed-off-by: Qxisylolo <[email protected]>

* update snapshot

Signed-off-by: Qxisylolo <[email protected]>

* add snapshot

Signed-off-by: Qxisylolo <[email protected]>

---------

Signed-off-by: Qxisylolo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <[email protected]>
(cherry picked from commit fb9a814)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.88%. Comparing base (544cf40) to head (e8fc21a).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ment_section/objects_table/saved_objects_table.tsx 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #9132   +/-   ##
=======================================
  Coverage   60.88%   60.88%           
=======================================
  Files        3807     3807           
  Lines       91131    91131           
  Branches    14379    14379           
=======================================
+ Hits        55485    55488    +3     
+ Misses      32119    32116    -3     
  Partials     3527     3527           
Flag Coverage Δ
Linux_1 29.03% <0.00%> (ø)
Linux_2 56.52% <ø> (ø)
Linux_3 37.84% <0.00%> (+<0.01%) ⬆️
Linux_4 30.02% <33.33%> (+<0.01%) ⬆️
Windows_1 29.04% <0.00%> (ø)
Windows_2 56.48% <ø> (ø)
Windows_3 37.84% <0.00%> (ø)
Windows_4 30.02% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am merged commit e4002b5 into 2.x Dec 31, 2024
68 of 73 checks passed
@github-actions github-actions bot deleted the backport/backport-8237-to-2.x branch December 31, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset v2.19.0 valued-contributor workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants