Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce code coverage collection to Cypress runs #9084

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AMoo-Miki
Copy link
Collaborator

Description

  • Introduce code coverage collection to Cypress runs
  • Add coverage reporting to Cypress CI
  • Enable Cypress tests to detect features of the OSD instance they are running against
  • Turn on test isolation when security is disabled

Changelog

  • test: Introduce code coverage collection to Cypress runs
  • test: Enable Cypress tests to detect features of the OSD instance they are running against
  • test: Turn on test isolation when security is disabled
  • infra: Add coverage reporting to Cypress CI

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Also:
* Add coverage reporting to Cypress CI
…running against

Also:
* Turn on test isolation when security is disabled

Signed-off-by: Miki <[email protected]>
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.87%. Comparing base (15a19fa) to head (1dfcc23).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
packages/osd-babel-preset/common_preset.js 50.00% 1 Missing ⚠️
src/core/server/http/http_server.ts 50.00% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (15a19fa) and HEAD (1dfcc23). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (15a19fa) HEAD (1dfcc23)
Linux_2 1 0
Linux_4 1 0
Linux_1 1 0
Windows_2 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9084      +/-   ##
==========================================
- Coverage   60.93%   51.87%   -9.07%     
==========================================
  Files        3809     3525     -284     
  Lines       91270    87361    -3909     
  Branches    14414    13796     -618     
==========================================
- Hits        55618    45321   -10297     
- Misses      32097    38993    +6896     
+ Partials     3555     3047     -508     
Flag Coverage Δ
Linux_1 ?
Linux_2 ?
Linux_4 ?
Windows_1 28.99% <50.00%> (+<0.01%) ⬆️
Windows_2 ?
Windows_3 37.96% <50.00%> (-0.01%) ⬇️
Windows_4 29.03% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LDrago27
LDrago27 previously approved these changes Dec 20, 2024
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Dec 20, 2024
ananzh
ananzh previously approved these changes Dec 27, 2024
@AMoo-Miki AMoo-Miki dismissed stale reviews from ananzh and LDrago27 via 1dfcc23 January 6, 2025 19:47
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although looks like some ci are failing

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this fix #975?

@AMoo-Miki
Copy link
Collaborator Author

would this fix #975?

I think https://github.com/AMoo-Miki/Compatibility-Tester and https://tests.aws.barahmand.com/ deal with that better.

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants