Re-enable dataset_selector.spec.js and queries.spec.js under workspace #9082

ananzh · 2024-12-19T23:10:22Z

Description

dataset_selector.spec.js

2024-12-19_14-52-14.mp4

queries.spec.js

2024-12-19_18-59-21.mp4

Note:

const scopedHistoryNavigationError = /^[^(ScopedHistory instance has fell out of navigation scope)]/;
Cypress.on('uncaught:exception', (err) => {
  /* returning false here prevents Cypress from failing the test */
  if (scopedHistoryNavigationError.test(err.message)) {
    return false;
  }
});

is from #9047

Issues Resolved

NA

Changelog

test: Re-enable dataset_selector.spec.js under workspace in ciGroup10

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

angle943 · 2024-12-19T23:21:02Z

...ration/core-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/constants.js

@@ -5,3 +5,5 @@

 export const DATASOURCE_NAME = 'query-cluster';
 export const WORKSPACE_NAME = 'query-workspace';
+export const START_TIME = 'Dec 31, 2020 @ 00:00:00.000';
+export const END_TIME = 'Dec 31, 2022 @ 23:59:59.999';


could we relax these dates to not make it so close to our dataset? more convo here: #9047 (comment)

good point. let me update it with other comments.

codecov · 2024-12-19T23:27:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.90%. Comparing base (f85cd6d) to head (bc81125).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9082      +/-   ##
==========================================
+ Coverage   60.86%   60.90%   +0.03%     
==========================================
  Files        3808     3808              
  Lines       91175    91178       +3     
  Branches    14396    14396              
==========================================
+ Hits        55495    55531      +36     
+ Misses      32140    32094      -46     
- Partials     3540     3553      +13

Flag	Coverage Δ
Linux_1	`28.99% <ø> (-0.01%)`	⬇️
Linux_2	`56.38% <ø> (-0.01%)`	⬇️
Linux_3	`38.01% <ø> (+0.06%)`	⬆️
Linux_4	`29.01% <ø> (-0.01%)`	⬇️
Windows_1	`29.00% <ø> (-0.01%)`	⬇️
Windows_2	`56.34% <ø> (-0.01%)`	⬇️
Windows_3	`38.01% <ø> (+0.06%)`	⬆️
Windows_4	`29.01% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Anan <[email protected]>

LDrago27 · 2024-12-20T17:21:53Z

...opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/dataset_selector.spec.js

-      miscUtils.visitPage(
-        `app/data-explorer/discover#/?_g=(filters:!(),time:(from:'2015-09-19T13:31:44.000Z',to:'2015-09-24T01:31:44.000Z'))`
-      );
+const miscUtils = new MiscUtils(cy);


Do we need the MiscUtils since we are only using this to for navigation which we can do using the cypress commands.

Plan to migrate MiscUtils.visitPage from lib to our cypress in a follow up

Signed-off-by: Anan <[email protected]>

abbyhu2000 · 2024-12-20T21:03:13Z

...opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/dataset_selector.spec.js

-const testFixtureHandler = new TestFixtureHandler(cy, PATHS.ENGINE);
-
-describe.skip('dataset selector', { scrollBehavior: false }, () => {
-  describe('empty state', () => {


why do we delete the test for testing the empty state? i think we do need to test when there is no index pattern

we moved it to a_check.spec.js

abbyhu2000 · 2024-12-20T21:08:55Z

...ion/core-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/queries.spec.js

      cy.waitForSearch();
      cy.getElementByTestId(`queryResultCompleteMsg`).should('be.visible');
-      cy.get('[class="euiText euiText--small"]').then((text) => cy.log(text));
-      cy.verifyHitCount(4);


Why do we delete verifying the hit count? If we delete verifying hit count, how are we ensuring the query is persisted across refresh?

Feel like cy.getElementByTestId(queryResultCompleteMsg).should('be.visible'); only does not provide valid proof

sure. I added cy.verifyHitCount('10,000');

Signed-off-by: Anan <[email protected]>

github-actions bot added the distinguished-contributor label Dec 19, 2024

opensearch-changeset-bot bot added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Dec 19, 2024

Changeset file for PR opensearch-project#9082 created/updated

d706016

angle943 reviewed Dec 19, 2024

View reviewed changes

Re-enable dataset_selector.spec.js and queries.spec.js under workspace

feaed99

Signed-off-by: Anan <[email protected]>

ananzh changed the title ~~Re-enable dataset_selector.spec.js under workspace~~ Re-enable dataset_selector.spec.js and queries.spec.js under workspace Dec 20, 2024

ananzh force-pushed the follow-up-9048-2 branch from d706016 to feaed99 Compare December 20, 2024 03:04

opensearch-changeset-bot bot added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Dec 20, 2024

Changeset file for PR opensearch-project#9082 created/updated

177981b

LDrago27 reviewed Dec 20, 2024

View reviewed changes

AMoo-Miki previously approved these changes Dec 20, 2024

View reviewed changes

fix comment

a1eb638

Signed-off-by: Anan <[email protected]>

ananzh dismissed AMoo-Miki’s stale review via a1eb638 December 20, 2024 20:48

ananzh force-pushed the follow-up-9048-2 branch from 177981b to a1eb638 Compare December 20, 2024 20:48

opensearch-changeset-bot bot added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Dec 20, 2024

Changeset file for PR opensearch-project#9082 created/updated

5d6bd5b

abbyhu2000 reviewed Dec 20, 2024

View reviewed changes

add verifyHitCount for PPL

0a4368b

Signed-off-by: Anan <[email protected]>

ananzh force-pushed the follow-up-9048-2 branch from 5d6bd5b to 0a4368b Compare December 20, 2024 21:23

Changeset file for PR opensearch-project#9082 created/updated

bc81125

AMoo-Miki approved these changes Dec 20, 2024

View reviewed changes

LDrago27 approved these changes Dec 20, 2024

View reviewed changes

sejli approved these changes Dec 20, 2024

View reviewed changes

ananzh merged commit 66331eb into opensearch-project:main Dec 20, 2024
69 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-enable dataset_selector.spec.js and queries.spec.js under workspace #9082

Re-enable dataset_selector.spec.js and queries.spec.js under workspace #9082

ananzh commented Dec 19, 2024 •

edited

Loading

angle943 Dec 19, 2024

ananzh Dec 20, 2024

ananzh Dec 20, 2024

codecov bot commented Dec 19, 2024 •

edited

Loading

LDrago27 Dec 20, 2024 •

edited

Loading

ananzh Dec 20, 2024

ananzh Dec 20, 2024 •

edited

Loading

abbyhu2000 Dec 20, 2024

ananzh Dec 20, 2024

abbyhu2000 Dec 20, 2024

ananzh Dec 20, 2024

Re-enable dataset_selector.spec.js and queries.spec.js under workspace #9082

Re-enable dataset_selector.spec.js and queries.spec.js under workspace #9082

Conversation

ananzh commented Dec 19, 2024 • edited Loading

Description

Issues Resolved

Changelog

Check List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 19, 2024 • edited Loading

Codecov Report

LDrago27 Dec 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ananzh Dec 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ananzh commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading

LDrago27 Dec 20, 2024 •

edited

Loading

ananzh Dec 20, 2024 •

edited

Loading