[Workspace] refactor: Remove permission validation in workspace form #9065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9065 +/- ##
==========================================
- Coverage 60.87% 60.86% -0.02%
==========================================
Files 3808 3808
Lines 91209 91159 -50
Branches 14410 14393 -17
==========================================
- Hits 55528 55480 -48
+ Misses 32140 32138 -2
Partials 3541 3541
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Signed-off-by: tygao <[email protected]>
ruanyl
approved these changes
Dec 18, 2024
Hailong-am
approved these changes
Dec 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
…9065) * refactor: remove permission verification in workspace form Signed-off-by: tygao <[email protected]> * Changeset file for PR #9065 created/updated * remove extra import in test Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> (cherry picked from commit c61c7cd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove permission validation in workspace form.
As collaborator section has been removed in workspace detail page, and permission value in workspace create page is fixed, we don't need this validation in workspace form any more.
Screenshot
Before you will see a permission error which would block workspace update in workspace detail page, now this will not exist.
Testing the changes
Go to workspace detail page and click edit, you won't see any form errors related to permission.
Changelog
Check List
yarn test:jestyarn test:jest_integration