Add missing data-test-subj tags for data plugin #9051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suchit Sahoo <[email protected]>
github-actions
bot
added
all-star-contributor
Skip-Changelog
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9051 +/- ##
==========================================
- Coverage 60.87% 60.84% -0.04%
==========================================
Files 3808 3808
Lines 91209 91209
Branches 14410 14410
==========================================
- Hits 55526 55492 -34
- Misses 32142 32222 +80
+ Partials 3541 3495 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LDrago27
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Signed-off-by: Suchit Sahoo <[email protected]>
ananzh
reviewed
Dec 13, 2024
src/plugins/data/public/query/query_string/language_service/lib/query_result.tsx
Outdated
Show resolved
Hide resolved
src/plugins/data/public/ui/query_editor/query_editor_top_row.tsx
Outdated
Show resolved
Hide resolved
LDrago27
force-pushed
the
addDataTEstSubj
branch
from
5bb43a9 to
0f42fcf
Compare
ananzh
reviewed
Dec 13, 2024
Signed-off-by: Suchit Sahoo <[email protected]>
LDrago27
force-pushed
the
addDataTEstSubj
branch
from
0f42fcf to
528982a
Compare
sejli
approved these changes
Dec 16, 2024
| @@ -150,7 +153,7 @@ export const SingleLineInput: React.FC<SingleLineInputProps> = ({ | |||
| triggerSuggestOnFocus={true} | |||
| /> | |||
| {editorIsFocused && ( | |||
| <div className="queryEditor__footer"> | |||
| <div className="queryEditor__footer" data-test-subj="queryEditorFooter"> | |||
There was a problem hiding this comment.
If I remember correctly, I added this for the single line editor's footer. Could be a little more descriptive for this to avoid confusion with the other editors.
ananzh
approved these changes
Dec 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Add missing data-test-subj tags for data plugin * Update Snapshots * Fix as per the comments --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> (cherry picked from commit 16115ba) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing data-test-subj tags for data plugin
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration