Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing data-test-subj tags for discover plugin #9049

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Add missing data-test-subj tags for discover plugin #9049

merged 4 commits into from
Dec 16, 2024

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Dec 12, 2024

Description

Add data-test-subj for discover

Issues Resolved

NA

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions github-actions bot added distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Dec 12, 2024
LDrago27
LDrago27 previously approved these changes Dec 12, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 37.94%. Comparing base (442e11e) to head (27732ff).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...over/public/application/components/chart/chart.tsx 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (442e11e) and HEAD (27732ff). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (442e11e) HEAD (27732ff)
Linux_3 2 1
Windows_2 9 0
Linux_2 1 0
Linux_4 1 0
Linux_1 1 0
Windows_4 1 0
Windows_3 1 0
Windows_1 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #9049       +/-   ##
===========================================
- Coverage   60.86%   37.94%   -22.93%     
===========================================
  Files        3808     2107     -1701     
  Lines       91209    57919    -33290     
  Branches    14410     9864     -4546     
===========================================
- Hits        55516    21975    -33541     
- Misses      32156    34198     +2042     
+ Partials     3537     1746     -1791
Flag Coverage Δ
Linux_1 ?
Linux_2 ?
Linux_3 37.94% <0.00%> (+<0.01%) ⬆️
Linux_4 ?
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh
fix comment
eff7dfc 
Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh force-pushed the test-subj-discover branch from 6cd3ce4 to eff7dfc Compare December 13, 2024 00:33
@ananzh ananzh changed the title Add data-test-subj for discover Add missing data-test-subj tags for discover plugin Dec 14, 2024
@LDrago27 LDrago27 merged commit f06a478 into opensearch-project:main Dec 16, 2024
67 of 69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 16, 2024
@github-actions
Add missing data-test-subj tags for discover plugin (#9049)
82222be 
* Add data-test-subj for discover
Signed-off-by: Anan Zhuang <[email protected]>
* fix comment
Signed-off-by: Anan Zhuang <[email protected]>

---------

Signed-off-by: Anan Zhuang <[email protected]>
(cherry picked from commit f06a478)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDrago27 LDrago27 LDrago27 approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ananzh @AMoo-Miki @LDrago27