update and unbranch webpack 4 dependency #9046
Conversation
Signed-off-by: Daniel Rowe <[email protected]>
d-rowe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9046 +/- ##
==========================================
- Coverage 60.87% 60.86% -0.02%
==========================================
Files 3808 3808
Lines 91209 91209
Branches 14410 14410
==========================================
- Hits 55526 55516 -10
- Misses 32142 32153 +11
+ Partials 3541 3540 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Didn't realize there were dozens of references to this branched webpack build. Will update as I get time. |
Signed-off-by: Daniel Rowe <[email protected]>
| axios@^1.6.5: | ||
| version "1.7.9" | ||
| resolved "https://registry.yarnpkg.com/axios/-/axios-1.7.9.tgz#d7d071380c132a24accda1b2cfc1535b79ec650a" | ||
| integrity sha512-LhLcE7Hbiryz8oMDdDptSrWowmB4Bl6RCt6sIJKpRB4XtVf0iEgewX3au/pJqm+Py1kCASkb/FFKjxQaLtxJvw== |
There was a problem hiding this comment.
Please combine with the previous block.
| chromedriver@^121.0.1: | ||
| version "121.0.2" |
There was a problem hiding this comment.
Any specific reason for this downgrade?
| component-emitter@^1.2.1: | ||
| version "1.3.1" |
There was a problem hiding this comment.
Please combine with the block below.
| micromatch@^3.1.10: | ||
| version "3.1.10" |
There was a problem hiding this comment.
This introduces a CVE: GHSA-952p-6rrq-rcjv
Perhaps this is another reason we kept using the custom release of webpack.
Description
We were previously using a custom branch of webpack 4 to support Node 18. This support has been added to webpack v4.47.0. This also will unify the webpack version with OUI once this change is merged
Changelog
Check List
yarn test:jestyarn test:jest_integration