Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workspace utility #9038

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add workspace utility #9038

merged 1 commit into from
Dec 11, 2024

Conversation

LDrago27
Copy link
Collaborator

Description

This PR adds certain workspace utility for the new Discover Experience with workspaces and query enhancements enabled.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@LDrago27
Add workspace utility
3c9ab52 
Signed-off-by: Suchit Sahoo <[email protected]>
@github-actions github-actions bot added all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Dec 11, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.89%. Comparing base (c6f5c8f) to head (3c9ab52).
Report is 1 commits behind head on cypress-unification.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##           cypress-unification    #9038   +/-   ##
====================================================
  Coverage                60.88%   60.89%           
====================================================
  Files                     3802     3802           
  Lines                    91083    91070   -13     
  Branches                 14383    14374    -9     
====================================================
  Hits                     55455    55455           
+ Misses                   32086    32074   -12     
+ Partials                  3542     3541    -1
Flag Coverage Δ
Linux_1 29.02% <ø> (-0.01%) ⬇️
Linux_2 56.39% <ø> (+<0.01%) ⬆️
Linux_3 37.89% <ø> (-0.01%) ⬇️
Linux_4 29.00% <ø> (+<0.01%) ⬆️
Windows_1 29.05% <ø> (+0.01%) ⬆️
Windows_2 56.34% <ø> (+<0.01%) ⬆️
Windows_3 37.90% <ø> (-0.01%) ⬇️
Windows_4 29.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDrago27 LDrago27 merged commit 6b58108 into opensearch-project:cypress-unification Dec 11, 2024
69 of 70 checks passed
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Dec 16, 2024
@ananzh
Follow up on opensearch-project#9048 by updating data and utilities
7112604 
Feature branch PRs:
opensearch-project#9038
opensearch-project#9006

Signed-off-by: Anan <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Dec 16, 2024
@ananzh
Follow up on opensearch-project#9048 by updating data and utilities
2bfdbb2 
Feature branch PRs:
opensearch-project#9038
opensearch-project#9006

Signed-off-by: Anan <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Dec 16, 2024
@ananzh
Follow up on opensearch-project#9048 by updating data and utilities
1ce8fe6 
Feature branch PRs:
opensearch-project#9038
opensearch-project#9006

Signed-off-by: Anan <[email protected]>
@ananzh ananzh mentioned this pull request Dec 16, 2024
Merged
7 tasks
LDrago27 pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Dec 16, 2024
@ananzh @LDrago27
Follow up on opensearch-project#9048 by updating data and utilities
b7f4609 
Feature branch PRs:
opensearch-project#9038
opensearch-project#9006

Signed-off-by: Anan <[email protected]>
ArgusLi pushed a commit to ArgusLi/OpenSearch-Dashboards that referenced this pull request Dec 17, 2024
@LDrago27 @ArgusLi
Add workspace utility (opensearch-project#9038)
3444f18 
Signed-off-by: Suchit Sahoo <[email protected]>
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Dec 18, 2024
@ananzh @AMoo-Miki
Follow up on opensearch-project#9048 by updating data and utilities
61a7c86 
Feature branch PRs:
opensearch-project#9038
opensearch-project#9006

Signed-off-by: Anan <[email protected]>
ananzh added a commit that referenced this pull request Dec 18, 2024
@ananzh
Follow up on #9048 by updating data and utilities (#9060)
f9c463d 
* Follow up on #9048 by updating data and utilities

Feature branch PRs:
#9038
#9006

Signed-off-by: Anan <[email protected]>

* fix comment

Signed-off-by: Anan <[email protected]>

* update path and add utility from suchit commit

Signed-off-by: Anan <[email protected]>

* update the path to run sample test

Signed-off-by: Anan <[email protected]>

* fix PR comments

Signed-off-by: Anan <[email protected]>

* skip tests before enable workspace

Signed-off-by: Anan <[email protected]>

---------

Signed-off-by: Anan <[email protected]>
@ArgusLi ArgusLi mentioned this pull request Dec 18, 2024
Open
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Dec 19, 2024
@ananzh @AMoo-Miki
Follow up on opensearch-project#9048 by updating data and utilities
08ff13e 
Feature branch PRs:
opensearch-project#9038
opensearch-project#9006

Signed-off-by: Anan <[email protected]>
ArgusLi added a commit to ArgusLi/OpenSearch-Dashboards that referenced this pull request Dec 19, 2024
@ArgusLi
Remove files added by commit opensearch-project#9038
4074b82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LDrago27 @abbyhu2000 @ananzh