Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace] fix:Prevent user from visiting dashboards / visualizations when out of a workspace #9024

Merged
merged 6 commits into from
Jan 6, 2025
Merged

[Workspace] fix:Prevent user from visiting dashboards / visualizations when out of a workspace #9024

merged 6 commits into from
Jan 6, 2025

Conversation

Qxisylolo
Copy link
Contributor

Description

This pr addresses:

  1. Prevent user from visiting dashboards / visualizations when out of a workspace by setting WorkspaceAvailability

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: Prevent user from visiting dashboards / visualizations when out of a workspace

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Dec 10, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#9024 created/updated
4194455
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.93%. Comparing base (40e61c7) to head (77f7f19).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/workspace/public/plugin.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9024   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files        3809     3809           
  Lines       91267    91270    +3     
  Branches    14413    14414    +1     
=======================================
+ Hits        55616    55618    +2     
  Misses      32097    32097           
- Partials     3554     3555    +1
Flag Coverage Δ
Linux_1 28.97% <66.66%> (+<0.01%) ⬆️
Linux_2 56.45% <ø> (ø)
Linux_3 37.96% <ø> (ø)
Linux_4 29.03% <ø> (ø)
Windows_1 28.98% <66.66%> (+<0.01%) ⬆️
Windows_2 56.40% <ø> (ø)
Windows_3 37.97% <ø> (ø)
Windows_4 29.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qxisylolo Qxisylolo marked this pull request as ready for review December 16, 2024 09:44
Hailong-am
Hailong-am approved these changes Dec 19, 2024
View reviewed changes
src/plugins/dashboard/public/plugin.tsx
import { UrlForwardingSetup, UrlForwardingStart } from 'src/plugins/url_forwarding/public';
import { isEmpty } from 'lodash';
import { createHashHistory } from 'history';
} from '../../../../src/core/public';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we can add one more import { WorkspaceAvailability } from '../../../../src/core/public' to avoid re-order

@SuZhou-Joe SuZhou-Joe force-pushed the fix/prevent_user_visit_dashboard_and_vis_when_out_of_workspace branch from 6f5b396 to 77f7f19 Compare January 3, 2025 08:21
@SuZhou-Joe SuZhou-Joe merged commit 15a19fa into opensearch-project:main Jan 6, 2025
75 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 6, 2025
@github-actions @opensearch-changeset-bot
[Workspace] fix:Prevent user from visiting dashboards / visualization…
a51e6fa 
…s when out of a workspace (#9024)

* add workspaceAvailability

Signed-off-by: Qxisylolo <[email protected]>

* Changeset file for PR #9024 created/updated

* add tests

Signed-off-by: Qxisylolo <[email protected]>

* update test

Signed-off-by: Qxisylolo <[email protected]>

* fix test use piple

Signed-off-by: Qxisylolo <[email protected]>

* fix test new

Signed-off-by: Qxisylolo <[email protected]>

---------

Signed-off-by: Qxisylolo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 15a19fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 6, 2025
Merged
silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Jan 7, 2025
@Qxisylolo @opensearch-changeset-bot @silvaf-dev
[Workspace] fix:Prevent user from visiting dashboards / visualization…
a9494b1 
…s when out of a workspace (opensearch-project#9024)

* add workspaceAvailability

Signed-off-by: Qxisylolo <[email protected]>

* Changeset file for PR opensearch-project#9024 created/updated

* add tests

Signed-off-by: Qxisylolo <[email protected]>

* update test

Signed-off-by: Qxisylolo <[email protected]>

* fix test use piple

Signed-off-by: Qxisylolo <[email protected]>

* fix test new

Signed-off-by: Qxisylolo <[email protected]>

---------

Signed-off-by: Qxisylolo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Jan 7, 2025
@Qxisylolo @opensearch-changeset-bot @silvaf-dev
[Workspace] fix:Prevent user from visiting dashboards / visualization…
dcaa54b 
…s when out of a workspace (opensearch-project#9024)

* add workspaceAvailability

Signed-off-by: Qxisylolo <[email protected]>

* Changeset file for PR opensearch-project#9024 created/updated

* add tests

Signed-off-by: Qxisylolo <[email protected]>

* update test

Signed-off-by: Qxisylolo <[email protected]>

* fix test use piple

Signed-off-by: Qxisylolo <[email protected]>

* fix test new

Signed-off-by: Qxisylolo <[email protected]>

---------

Signed-off-by: Qxisylolo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>
SuZhou-Joe pushed a commit that referenced this pull request Jan 9, 2025
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @ruanyl
[Workspace] fix:Prevent user from visiting dashboards / visualization…
2e418ec 
…s when out of a workspace (#9024) (#9144)

* add workspaceAvailability



* Changeset file for PR #9024 created/updated

* add tests



* update test



* fix test use piple



* fix test new



---------



(cherry picked from commit 15a19fa)

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x seasoned-contributor v2.19.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Qxisylolo @ruanyl @SuZhou-Joe @Hailong-am