Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Discover] fix PPL to not throw error if aggregation query fails #8998

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[Backport 2.x] [Discover] fix PPL to not throw error if aggregation query fails #8998

merged 1 commit into from
Dec 3, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d5e0087 from #8992.

@github-actions
[Discover] fix PPL to not throw error if aggregation query fails (#8992)
ccdf06f 
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit d5e0087)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports all-star-contributor failed changeset labels Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.91%. Comparing base (657ff20) to head (ccdf06f).
Report is 2 commits behind head on 2.x.

Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #8998   +/-   ##
=======================================
  Coverage   60.91%   60.91%           
=======================================
  Files        3801     3802    +1     
  Lines       91050    91073   +23     
  Branches    14366    14371    +5     
=======================================
+ Hits        55459    55480   +21     
  Misses      32065    32065           
- Partials     3526     3528    +2
Flag Coverage Δ
Linux_1 29.04% <ø> (ø)
Linux_2 56.52% <ø> (ø)
Linux_3 37.83% <ø> (ø)
Linux_4 30.03% <100.00%> (+0.02%) ⬆️
Windows_1 29.06% <ø> (ø)
Windows_2 56.48% <ø> (ø)
Windows_3 37.83% <ø> (ø)
Windows_4 30.03% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@virajsanghvi virajsanghvi merged commit 0691c1f into 2.x Dec 3, 2024
69 of 72 checks passed
@github-actions github-actions bot deleted the backport/backport-8992-to-2.x branch December 3, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor autocut Skip the changelog verification check on backports failed changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virajsanghvi @joshuali925