Fix query editor cursor alignment by removing monaco css overrides #8912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monaco editor computes the cursor position internally and does not account for any css overrides that change the position of the line (padding, margin, etc). This change removes the css override while we implement these styles with the monaco api directly. Signed-off-by: Daniel Rowe <[email protected]>
d-rowe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
ashwin-pc
previously approved these changes
Nov 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8912 +/- ##
==========================================
+ Coverage 60.86% 60.87% +0.01%
==========================================
Files 3802 3802
Lines 91059 91060 +1
Branches 14370 14370
==========================================
+ Hits 55425 55437 +12
+ Misses 32095 32084 -11
Partials 3539 3539
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Hailong-am
previously approved these changes
Nov 22, 2024
|
Can you fix the lint? |
Signed-off-by: Daniel Rowe <[email protected]>
d-rowe
commented
Nov 22, 2024
Sure thing, I've fixed the linting issue. |
virajsanghvi
approved these changes
Nov 22, 2024
Yup, I've added before and after screenshots in the PR description |
Hailong-am
approved these changes
Nov 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
…8912) * Fix query editor cursor alignment by removing monaco css overrides Monaco editor computes the cursor position internally and does not account for any css overrides that change the position of the line (padding, margin, etc). This change removes the css override while we implement these styles with the monaco api directly. Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #8912 created/updated * fix linting Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit f110637) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
silva-qa
pushed a commit
to silva-qa/OpenSearch-Dashboards
that referenced
this pull request
Dec 12, 2024
…pensearch-project#8912) * Fix query editor cursor alignment by removing monaco css overrides Monaco editor computes the cursor position internally and does not account for any css overrides that change the position of the line (padding, margin, etc). This change removes the css override while we implement these styles with the monaco api directly. Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR opensearch-project#8912 created/updated * fix linting Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: Federico Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Monaco editor computes the cursor position internally and does not account for any css overrides that change the position of the line (padding, margin, etc). This change removes the css override while we implement these styles with the monaco api directly.
Changelog
Before
After
Check List
yarn test:jestyarn test:jest_integration