[Workspace] feat: optimize recent items and filter out items whose workspace is deleted #8900

raintygao · 2024-11-20T03:40:00Z

Description

optimize recent items
filter out items whose workspace is deleted

Screenshot

No UI change

Testing the changes

Update internal users to emit app updaters and recent items would not send extra request
Filter out items whose workspace is deleted

Changelog

feat: Optimize recent items and filter out items whose workspace is deleted

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-11-20T03:55:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.87%. Comparing base (89265b6) to head (03c6825).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8900   +/-   ##
=======================================
  Coverage   60.87%   60.87%           
=======================================
  Files        3802     3802           
  Lines       91060    91060           
  Branches    14370    14370           
=======================================
+ Hits        55435    55436    +1     
+ Misses      32085    32084    -1     
  Partials     3540     3540

Flag	Coverage Δ
Linux_1	`29.01% <0.00%> (ø)`
Linux_2	`56.38% <100.00%> (-0.01%)`	⬇️
Linux_3	`37.90% <0.00%> (?)`
Linux_4	`29.00% <0.00%> (ø)`
Windows_1	`29.03% <0.00%> (ø)`
Windows_2	`56.34% <100.00%> (-0.01%)`	⬇️
Windows_3	`37.90% <0.00%> (ø)`
Windows_4	`29.00% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wanglam · 2024-11-20T07:28:21Z

src/core/public/chrome/ui/header/recent_items.tsx

@@ -213,45 +226,45 @@ export const RecentItems = ({
        type: item.meta?.type || '',
        id: item.id,
      }));
-
-    if (savedObjects.length) {
+    // Deep compare navLinks to avoid unnecessary requests


How about using useDeepCompareEffect instead? Current implementation won't be executed again after other dependencies(eg: recentlyAccessedItems or workspaceList ) changed but navLinks are same.

After offline discussion, we only need to deep compare navLinks because only its reference would be changed after appUpdater.

wanglam · 2024-11-20T07:29:16Z

src/core/public/chrome/ui/header/recent_items.tsx

-              .href,
-          };
+          // If the workspace id is existing but the workspace is deleted, filter the item
+          if (recentAccessItem.workspaceId && !findWorkspace) {


Do we need to check if workspace feature enabled here?

If workspace feature is disabled, recentAccessItem would not have workspaceId.

Hailong-am · 2024-11-21T10:13:47Z

src/core/public/chrome/ui/header/recent_items.tsx

      bulkGetDetail(savedObjects, http).then((res) => {
-        const filteredNavLinks = navLinks.filter((link) => !link.hidden);
-        const formatDetailedSavedObjects = res.map((obj) => {
+        const formatDetailedSavedObjects = res.flatMap((obj) => {


can we do filtering by workspace before bulkGet as ChromeRecentlyAccessedHistoryItem has workspace already.

…eleted Signed-off-by: tygao <[email protected]>

Signed-off-by: tygao <[email protected]>

…rkspace is deleted (#8900) * feat: optimize recent items and filter out items whose workspace is deleted Signed-off-by: tygao <[email protected]> * Changeset file for PR #8900 created/updated * seperate link Signed-off-by: tygao <[email protected]> * update filter sequence Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit c24d5bc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…rkspace is deleted (#8900) (#8983) * feat: optimize recent items and filter out items whose workspace is deleted * Changeset file for PR #8900 created/updated * seperate link * update filter sequence --------- (cherry picked from commit c24d5bc) Signed-off-by: tygao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…rkspace is deleted (opensearch-project#8900) * feat: optimize recent items and filter out items whose workspace is deleted Signed-off-by: tygao <[email protected]> * Changeset file for PR opensearch-project#8900 created/updated * seperate link Signed-off-by: tygao <[email protected]> * update filter sequence Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…rkspace is deleted (opensearch-project#8900) * feat: optimize recent items and filter out items whose workspace is deleted Signed-off-by: tygao <[email protected]> * Changeset file for PR opensearch-project#8900 created/updated * seperate link Signed-off-by: tygao <[email protected]> * update filter sequence Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: Federico Silva <[email protected]>

…rkspace is deleted (opensearch-project#8900) * feat: optimize recent items and filter out items whose workspace is deleted Signed-off-by: tygao <[email protected]> * Changeset file for PR opensearch-project#8900 created/updated * seperate link Signed-off-by: tygao <[email protected]> * update filter sequence Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

github-actions bot added the all-star-contributor label Nov 20, 2024

opensearch-changeset-bot bot added a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Nov 20, 2024

Changeset file for PR opensearch-project#8900 created/updated

3dff82b

wanglam reviewed Nov 20, 2024

View reviewed changes

raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Nov 20, 2024

Changeset file for PR opensearch-project#8900 created/updated

3877047

raintygao force-pushed the recnet branch from 8612b06 to e7950b8 Compare November 20, 2024 09:38

SuZhou-Joe previously approved these changes Nov 21, 2024

View reviewed changes

SuZhou-Joe added backport 2.x workspace labels Nov 21, 2024

Hailong-am reviewed Nov 21, 2024

View reviewed changes

raintygao dismissed SuZhou-Joe’s stale review via f32ac92 November 22, 2024 05:34

raintygao and others added 4 commits November 22, 2024 13:34

feat: optimize recent items and filter out items whose workspace is d…

eec50cd

…eleted Signed-off-by: tygao <[email protected]>

Changeset file for PR opensearch-project#8900 created/updated

16f804b

seperate link

bc4aa4b

Signed-off-by: tygao <[email protected]>

update filter sequence

03c6825

Signed-off-by: tygao <[email protected]>

raintygao force-pushed the recnet branch from f32ac92 to 03c6825 Compare November 22, 2024 05:35

Hailong-am approved these changes Nov 25, 2024

View reviewed changes

SuZhou-Joe approved these changes Nov 27, 2024

View reviewed changes

SuZhou-Joe merged commit c24d5bc into opensearch-project:main Nov 27, 2024
69 checks passed

opensearch-trigger-bot bot mentioned this pull request Nov 27, 2024

[Backport 2.x] [Workspace] feat: optimize recent items and filter out items whose workspace is deleted #8983

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace] feat: optimize recent items and filter out items whose workspace is deleted #8900

[Workspace] feat: optimize recent items and filter out items whose workspace is deleted #8900

raintygao commented Nov 20, 2024

codecov bot commented Nov 20, 2024 •

edited

Loading

wanglam Nov 20, 2024

raintygao Nov 20, 2024

wanglam Nov 20, 2024

raintygao Nov 20, 2024

Hailong-am Nov 21, 2024

[Workspace] feat: optimize recent items and filter out items whose workspace is deleted #8900

[Workspace] feat: optimize recent items and filter out items whose workspace is deleted #8900

Conversation

raintygao commented Nov 20, 2024

Description

Screenshot

Testing the changes

Changelog

Check List

codecov bot commented Nov 20, 2024 • edited Loading

Codecov Report

wanglam Nov 20, 2024

Choose a reason for hiding this comment

raintygao Nov 20, 2024

Choose a reason for hiding this comment

wanglam Nov 20, 2024

Choose a reason for hiding this comment

raintygao Nov 20, 2024

Choose a reason for hiding this comment

Hailong-am Nov 21, 2024

Choose a reason for hiding this comment

codecov bot commented Nov 20, 2024 •

edited

Loading