-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: staled closure inside chrome_service #8783
Conversation
Signed-off-by: SuZhou-Joe <[email protected]>
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8783 +/- ##
=======================================
Coverage 60.75% 60.75%
=======================================
Files 3798 3798
Lines 90690 90690
Branches 14277 14277
=======================================
Hits 55101 55101
Misses 32090 32090
Partials 3499 3499
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
const appHidden$ = merge( | ||
// For the isVisible$ logic, having no mounted app is equivalent to having a hidden app | ||
// in the sense that the chrome UI should not be displayed until a non-chromeless app is mounting or mounted | ||
of(true), | ||
application.currentAppId$.pipe( | ||
flatMap((appId) => | ||
application.applications$.pipe( | ||
flatMap((appId) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems change to switchMap
could solve the issue?
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8783-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e11b4013599fa5fe39097275a53e68a39de44570
# Push it to GitHub
git push --set-upstream origin backport/backport-8783-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.18 2.18
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.18
# Create a new branch
git switch --create backport/backport-8783-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e11b4013599fa5fe39097275a53e68a39de44570
# Push it to GitHub
git push --set-upstream origin backport/backport-8783-to-2.18
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.18 Then, create a pull request where the |
(cherry picked from commit e11b401)
(cherry picked from commit e11b401) Signed-off-by: SuZhou-Joe <[email protected]>
(cherry picked from commit e11b401) Signed-off-by: SuZhou-Joe <[email protected]>
Description
Fix staled closure issue inside chrome_service. The staled closure is toggling the chrome from visible to unvisible and visible in a short time and it makes the page header remount multiple times.
Issues Resolved
Screenshot
Before fix
20241101135015249.mp4
After fix
20241101135140983.mp4
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration