Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Compress the OuiSearchBar instances used on Advanced Settings and Saved Object Management pages #8474

Merged
merged 1 commit into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ export class AdvancedSettingsComponent extends Component<
if (!this.props.useUpdatedUX) {
return (
<>
<EuiSpacer size="m" />
<EuiFlexGroup gutterSize="none">
<EuiFlexItem>
<PageTitle />
Expand All @@ -255,6 +254,7 @@ export class AdvancedSettingsComponent extends Component<
<PageSubtitle />
<EuiSpacer size="m" />
<CallOuts />
<EuiSpacer size="m" />
</>
);
} else {
Expand All @@ -270,7 +270,7 @@ export class AdvancedSettingsComponent extends Component<
]}
/>
<Search query={query} categories={this.categories} onQueryChange={this.onQueryChange} />
<EuiSpacer size="m" />
<EuiSpacer size="s" />
</>
);
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,22 @@ export class Search extends PureComponent<SearchProps> {
);
}

/* The `onChange` and `query` attributes below throw type errors for `_AST` and `Query` because
* OSD imports the types from the `eui` aliases which makes typescript believe that they are
* different.
*/

return (
<Fragment>
{/* @ts-ignore The Query types that typescript complains about here are identical and is a false flag. Once OUI migration is complete, this ignore can be removed */}
<EuiSearchBar box={box} filters={filters} onChange={this.onChange} query={query} />
<EuiSearchBar
compressed
box={box}
filters={filters}
// @ts-expect-error
onChange={this.onChange}
// @ts-expect-error
query={query}
/>
{queryParseError}
</Fragment>
);
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,7 @@ export class Table extends PureComponent<TableProps, TableState> {
{activeActionContents}
<EuiSearchBar
box={{ 'data-test-subj': 'savedObjectSearchBar' }}
compressed
filters={filters}
onChange={this.onChange}
toolsRight={[
Expand Down
Loading