-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data-connection objects title in saved-objects page #8209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to goyamegh/OpenSearch-Dashboards
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Megha Goyal <[email protected]>
goyamegh
force-pushed
the
data-connection
branch
from
September 17, 2024 01:30
8702484
to
59bd738
Compare
goyamegh
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
September 17, 2024 01:31
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8209 +/- ##
==========================================
- Coverage 64.05% 64.05% -0.01%
==========================================
Files 3741 3741
Lines 88630 88629 -1
Branches 13801 13801
==========================================
- Hits 56772 56771 -1
Misses 31260 31260
Partials 598 598
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amsiglan
approved these changes
Sep 17, 2024
ashwin-pc
approved these changes
Sep 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit b826df8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Sep 17, 2024
(cherry picked from commit b826df8) Signed-off-by: Megha Goyal <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix data-connection objects title in saved-objects page
Issues Resolved
NA
Screenshot
Testing the changes
Tested by rendering the saved objects list page.
Changelog
Check List
yarn test:jest
yarn test:jest_integration