Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [query assist] use badge to show agent errors #8146

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[Backport 2.x] [query assist] use badge to show agent errors #8146

merged 1 commit into from
Sep 12, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 461a395 from #7998.

@github-actions
[query assist] use badge to show agent errors (#7998)
fa7f70a 
- enable query assist for index patterns without data source
- add agent error parsing utils
- update ml-commons response schema processing
   - previously ml-commons returns error.body as a string, now it is a JSON object. Ideally frontend should keep it as is to reduce serializing/deserializing, but since older version of ml-commons can be used through MDS, we'll keep it as a string for consistency
- use badge to show query assist error if possible
- add unit tests

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 461a395)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added discover for discover reinvent autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry seasoned-contributor v2.18.0 labels Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Sep 11, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.97%. Comparing base (a8fca1c) to head (fa7f70a).
Report is 90 commits behind head on 2.x.

Files with missing lines Patch % Lines
...s/public/query_assist/components/warning_badge.tsx 77.77% 4 Missing ⚠️
...nts/public/query_assist/utils/create_extension.tsx 0.00% 0 Missing and 1 partial ⚠️
...y_enhancements/public/query_assist/utils/errors.ts 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #8146      +/-   ##
==========================================
+ Coverage   63.92%   63.97%   +0.05%     
==========================================
  Files        3737     3738       +1     
  Lines       88717    88746      +29     
  Branches    13792    13799       +7     
==========================================
+ Hits        56713    56779      +66     
+ Misses      31408    31372      -36     
+ Partials      596      595       -1
Flag Coverage Δ
Linux_1 29.96% <ø> (ø)
Linux_2 58.91% <ø> (ø)
Linux_3 40.29% <ø> (+<0.01%) ⬆️
Linux_4 31.48% <81.25%> (+0.15%) ⬆️
Windows_1 29.97% <ø> (ø)
Windows_2 58.86% <ø> (ø)
Windows_3 40.29% <ø> (ø)
Windows_4 31.48% <81.25%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla merged commit 5cce5a0 into 2.x Sep 12, 2024
69 of 71 checks passed
@ashwin-pc ashwin-pc added 2.17.1 and removed v2.18.0 labels Sep 17, 2024
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
@opensearch-trigger-bot @github-actions @SuZhou-Joe
[query assist] use badge to show agent errors (opensearch-project#7998)…
6054c0c 
… (opensearch-project#8146)

- enable query assist for index patterns without data source
- add agent error parsing utils
- update ml-commons response schema processing
   - previously ml-commons returns error.body as a string, now it is a JSON object. Ideally frontend should keep it as is to reduce serializing/deserializing, but since older version of ml-commons can be used through MDS, we'll keep it as a string for consistency
- use badge to show query assist error if possible
- add unit tests


(cherry picked from commit 461a395)

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
2.17.1 autocut Skip the changelog verification check on backports discover for discover reinvent discover-next failed changeset seasoned-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashwin-pc @joshuali925 @kavilla @SuZhou-Joe