Fix the display and jump logic for recent assets #8136

Kapian1234 · 2024-09-11T08:37:41Z

Description

Filter out global objects in recently viewed assets when workspace is enabled.
In recently accessed, when workspace disabled, it should jump to the global visualization/dashboard page (ignore the workspace of the current saved object).

Issues Resolved

Screenshot

Testing the changes

Changelog

fix: Fix the display and jump logic for recent assets

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

… to the global for workspace objects hwen workspace disabled Signed-off-by: Kapian1234 <[email protected]>

codecov · 2024-09-11T12:08:07Z

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.98%. Comparing base (87011f7) to head (bef66a3).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
...ome/recently_accessed/recently_accessed_service.ts	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8136      +/-   ##
==========================================
+ Coverage   60.90%   60.98%   +0.07%     
==========================================
  Files        3808     3812       +4     
  Lines       91196    91389     +193     
  Branches    14400    14439      +39     
==========================================
+ Hits        55547    55731     +184     
- Misses      32096    32098       +2     
- Partials     3553     3560       +7

Flag	Coverage Δ
Linux_1	`29.07% <0.00%> (+0.07%)`	⬆️
Linux_2	`56.45% <85.71%> (+0.06%)`	⬆️
Linux_3	`37.97% <0.00%> (-0.05%)`	⬇️
Linux_4	`29.03% <12.50%> (+0.01%)`	⬆️
Windows_1	`29.09% <0.00%> (+0.07%)`	⬆️
Windows_2	`56.40% <85.71%> (+0.06%)`	⬆️
Windows_3	`37.97% <0.00%> (-0.05%)`	⬇️
Windows_4	`29.03% <12.50%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kapian1234 <[email protected]>

…boards into recent_assets

Signed-off-by: Kapian1234 <[email protected]>

wanglam · 2024-09-12T02:53:08Z

src/core/public/chrome/recently_accessed/recently_accessed_service.ts

+      get$: () => {
+        return history.get$().pipe(
+          map((items) => {
+            return items.filter((item) => (workspaceEnabled ? !!item.workspaceId : true));


Can we add some UT to test this filtering logic?

wanglam · 2024-09-12T02:54:49Z

src/core/public/chrome/ui/header/nav_link.tsx

-      withoutClientBasePath: true,
-    })
+    basePath.prepend(
+      formatUrlWithWorkspaceId(link, workspaceEnabled ? workspaceId || '' : '', basePath),


This logic looks a little bit strange to me, I think we don't need to call formatUrlWithWorkspaceId if workspaceEnabled equal false. How about refactor with below code?

Suggested change

formatUrlWithWorkspaceId(link, workspaceEnabled ? workspaceId || '' : '', basePath),

workspaceEnabled ? formatUrlWithWorkspaceId(link, workspaceId || '', basePath) : link,

By the way, can we add some unit tests about it?

Hailong-am · 2024-09-12T04:00:24Z

src/core/public/chrome/recently_accessed/recently_accessed_service.ts

@@ -81,10 +84,16 @@ export class RecentlyAccessedService {
      },

      /** Gets the current array of history items. */
-      get: () => history.get(),
+      get: () => history.get().filter((item) => !!item.workspaceId),


will this impact workspace disabled case? I think we should check workspaceEnabled flag

yes I forgot it here, thx for reminding!

Signed-off-by: Kapian1234 <[email protected]>

…ch-Dashboards into recent_assets

ananzh · 2024-10-30T19:22:35Z

@Kapian1234 thanks for the contribution. Could you check and fix the comment? I think we could release this for 2.19. Will leave @SuZhou-Joe and @ruanyl to make the call.

…ch-Dashboards into recent_assets

Signed-off-by: Kapian1234 <[email protected]>

…boards into recent_assets

Kapian1234 · 2024-11-04T02:16:39Z

@Kapian1234 thanks for the contribution. Could you check and fix the comment? I think we could release this for 2.19. Will leave @SuZhou-Joe and @ruanyl to make the call.

ok

Signed-off-by: Kapian1234 <[email protected]>

…boards into recent_assets

Signed-off-by: Kapian1234 <[email protected]>

UT failed

SuZhou-Joe · 2024-12-24T08:14:16Z

@Kapian1234 , bootstrap failed, could you please take a look?

Signed-off-by: Kapian1234 <[email protected]>

Kapian1234 · 2024-12-24T08:26:43Z

@Kapian1234 , bootstrap failed, could you please take a look?

ok

Signed-off-by: Kapian1234 <[email protected]>

wanglam · 2025-01-09T02:36:45Z

src/core/public/chrome/ui/header/nav_link.test.tsx

@@ -103,6 +103,6 @@ describe('createRecentNavLink', () => {
      mockedNavigateToUrl
    );

-    expect(recentLink.href).toEqual('http://localhost/test/w/foo/app/foo');
+    expect(recentLink.href).toEqual('http://localhost/test/app/foo');


Shall we need to add test case for workspace disabled?

Signed-off-by: Kapian1234 <[email protected]>

…boards into recent_assets

Hide global objects in recent assets when workspace enabled, and jump…

4707fac

… to the global for workspace objects hwen workspace disabled Signed-off-by: Kapian1234 <[email protected]>

github-actions bot added the valued-contributor label Sep 11, 2024

Changeset file for PR opensearch-project#8136 created/updated

66f2b68

Kapian1234 added 3 commits September 12, 2024 10:33

Update recently-accessed-service

5a07c11

Signed-off-by: Kapian1234 <[email protected]>

Merge branch 'recent_assets' of github.com:Kapian1234/OpenSearch-Dash…

8ff5a28

…boards into recent_assets

fix the boolean value

9a540d3

Signed-off-by: Kapian1234 <[email protected]>

wanglam reviewed Sep 12, 2024

View reviewed changes

Hailong-am reviewed Sep 12, 2024

View reviewed changes

add unit test and fix some bugs

3340ea8

Signed-off-by: Kapian1234 <[email protected]>

Kapian1234 marked this pull request as ready for review September 12, 2024 05:43

Kapian1234 requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT, xinruiba, zhyuanqi and mengweieric as code owners September 12, 2024 05:43

Kapian1234 dismissed ruanyl’s stale review via 37db157 September 30, 2024 04:08

resolve conflicts

8fff3cf

Signed-off-by: Kapian1234 <[email protected]>

ruanyl added the workspace label Oct 29, 2024

Kapian1234 and others added 2 commits October 29, 2024 17:22

Merge branch 'main' of https://github.com/opensearch-project/OpenSear…

e4fe87c

…ch-Dashboards into recent_assets

Merge branch 'main' into recent_assets

879917e

ananzh added v2.19.0 and removed v2.19.0 labels Oct 30, 2024

SuZhou-Joe added the v2.19.0 label Oct 30, 2024

Kapian1234 added 3 commits November 4, 2024 09:55

Merge branch 'main' of https://github.com/opensearch-project/OpenSear…

ea1e2ab

…ch-Dashboards into recent_assets

Update unit tests

0d046b9

Signed-off-by: Kapian1234 <[email protected]>

Merge branch 'recent_assets' of github.com:Kapian1234/OpenSearch-Dash…

291e82d

…boards into recent_assets

SuZhou-Joe and others added 4 commits November 15, 2024 10:09

Merge branch 'main' into recent_assets

07a6f74

Resolve conflicts

af72d86

Signed-off-by: Kapian1234 <[email protected]>

Merge branch 'recent_assets' of github.com:Kapian1234/OpenSearch-Dash…

9c0064e

…boards into recent_assets

Remove workspaceEnabled props in recent_items

7c28a46

Signed-off-by: Kapian1234 <[email protected]>

SuZhou-Joe previously approved these changes Dec 24, 2024

View reviewed changes

Fix links at recent accessed items

0c92d9e

Signed-off-by: Kapian1234 <[email protected]>

Kapian1234 and others added 3 commits December 25, 2024 15:23

Fix unit tests

4c83a8c

Signed-off-by: Kapian1234 <[email protected]>

Update snapshots

101c4b8

Signed-off-by: Kapian1234 <[email protected]>

Merge branch 'main' into recent_assets

d6ee2f1

SuZhou-Joe previously approved these changes Dec 30, 2024

View reviewed changes

wanglam reviewed Jan 9, 2025

View reviewed changes

Kapian1234 added 2 commits January 9, 2025 14:44

Modify unit tests

4d375a1

Signed-off-by: Kapian1234 <[email protected]>

Merge branch 'recent_assets' of github.com:Kapian1234/OpenSearch-Dash…

bef66a3

…boards into recent_assets

Kapian1234 dismissed SuZhou-Joe’s stale review via bef66a3 January 9, 2025 06:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the display and jump logic for recent assets #8136

Fix the display and jump logic for recent assets #8136

Kapian1234 commented Sep 11, 2024

codecov bot commented Sep 11, 2024 •

edited

Loading

wanglam Sep 12, 2024

wanglam Sep 12, 2024

Kapian1234 Sep 12, 2024

Hailong-am Sep 12, 2024

Kapian1234 Sep 12, 2024

ananzh commented Oct 30, 2024 •

edited

Loading

Kapian1234 commented Nov 4, 2024

SuZhou-Joe commented Dec 24, 2024

Kapian1234 commented Dec 24, 2024

wanglam Jan 9, 2025

Kapian1234 Jan 9, 2025

	formatUrlWithWorkspaceId(link, workspaceEnabled ? workspaceId \|\| '' : '', basePath),
	workspaceEnabled ? formatUrlWithWorkspaceId(link, workspaceId \|\| '', basePath) : link,

Fix the display and jump logic for recent assets #8136

Are you sure you want to change the base?

Fix the display and jump logic for recent assets #8136

Conversation

Kapian1234 commented Sep 11, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

codecov bot commented Sep 11, 2024 • edited Loading

Codecov Report

wanglam Sep 12, 2024

Choose a reason for hiding this comment

wanglam Sep 12, 2024

Choose a reason for hiding this comment

Kapian1234 Sep 12, 2024

Choose a reason for hiding this comment

Hailong-am Sep 12, 2024

Choose a reason for hiding this comment

Kapian1234 Sep 12, 2024

Choose a reason for hiding this comment

ananzh commented Oct 30, 2024 • edited Loading

Kapian1234 commented Nov 4, 2024

SuZhou-Joe commented Dec 24, 2024

Kapian1234 commented Dec 24, 2024

wanglam Jan 9, 2025

Choose a reason for hiding this comment

Kapian1234 Jan 9, 2025

Choose a reason for hiding this comment

codecov bot commented Sep 11, 2024 •

edited

Loading

ananzh commented Oct 30, 2024 •

edited

Loading