[Discover] Fix refresh on index #8121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbyhu2000
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
opensearch-changeset-bot bot
added a commit
to abbyhu2000/OpenSearch-Dashboards
that referenced
this pull request
Sep 10, 2024
kavilla
reviewed
Sep 10, 2024
| @@ -95,7 +105,8 @@ export const useIndexPattern = (services: DiscoverViewServices) => { | |||
| store, | |||
| toastNotifications, | |||
| uiSettings, | |||
| query?.dataset, | |||
| query.dataset, | |||
There was a problem hiding this comment.
yes, it will be default query if not passed in
kavilla
previously approved these changes
Sep 10, 2024
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
force-pushed
the
fix_refresh_on_index
branch
from
3d2472a to
0f8dff1
Compare
ashwin-pc
approved these changes
Sep 10, 2024
kavilla
approved these changes
Sep 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit 1d36fd3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit 1d36fd3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8121 +/- ##
==========================================
- Coverage 63.84% 63.84% -0.01%
==========================================
Files 3738 3738
Lines 88701 88704 +3
Branches 13794 13795 +1
==========================================
- Hits 56630 56629 -1
- Misses 31474 31478 +4
Partials 597 597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
pushed a commit
that referenced
this pull request
Sep 10, 2024
(cherry picked from commit 1d36fd3) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc
pushed a commit
that referenced
this pull request
Sep 11, 2024
(cherry picked from commit 1d36fd3) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix refresh when selecting an index. Previously, discover will be stuck on loading.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration