Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the size of disabled ValidatedDualRange components in InputControl visualizations #8108

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Sep 10, 2024

Description

Correctly size of disabled ValidatedDualRange components in InputControl visualizations

Screenshot

Before:

After:

Changelog

  • fix: Correct the size of disabled ValidatedDualRange components in InputControl visualizations

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

LDrago27
LDrago27 previously approved these changes Sep 10, 2024
virajsanghvi
virajsanghvi previously approved these changes Sep 10, 2024
opensearch-changeset-bot bot added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Sep 10, 2024
@AMoo-Miki AMoo-Miki changed the title Correctly size of disabled ValidatedDualRange components in InputControl visualizations Correct size of disabled ValidatedDualRange components in InputControl visualizations Sep 10, 2024
LDrago27
LDrago27 previously approved these changes Sep 10, 2024
virajsanghvi
virajsanghvi previously approved these changes Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.71%. Comparing base (22f1d46) to head (a1d4c9c).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8108   +/-   ##
=======================================
  Coverage   63.71%   63.71%           
=======================================
  Files        3738     3738           
  Lines       88682    88699   +17     
  Branches    13788    13793    +5     
=======================================
+ Hits        56501    56516   +15     
+ Misses      31593    31592    -1     
- Partials      588      591    +3     
Flag Coverage Δ
Linux_1 29.96% <ø> (ø)
Linux_2 58.79% <ø> (ø)
Linux_3 40.06% <ø> (+0.01%) ⬆️
Linux_4 31.20% <100.00%> (ø)
Windows_1 29.97% <ø> (ø)
Windows_2 58.74% <ø> (ø)
Windows_3 40.07% <ø> (+0.01%) ⬆️
Windows_4 31.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

opensearch-changeset-bot bot added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Sep 10, 2024
@AMoo-Miki AMoo-Miki changed the title Correct size of disabled ValidatedDualRange components in InputControl visualizations Correct the size of disabled ValidatedDualRange components in InputControl visualizations Sep 10, 2024
LDrago27
LDrago27 previously approved these changes Sep 10, 2024
virajsanghvi
virajsanghvi previously approved these changes Sep 10, 2024
Signed-off-by: Miki <[email protected]>
@AMoo-Miki AMoo-Miki dismissed stale reviews from virajsanghvi and LDrago27 via a1d4c9c September 10, 2024 20:01
@AMoo-Miki AMoo-Miki merged commit 7aecd73 into opensearch-project:main Sep 11, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 11, 2024
…ntrol visualizations (#8108)

* Correct the size of disabled ValidatedDualRange components in InputControl visualizations

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #8108 created/updated

* Update snapshot

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7aecd73)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 11, 2024
…ntrol visualizations (#8108)

* Correct the size of disabled ValidatedDualRange components in InputControl visualizations

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #8108 created/updated

* Update snapshot

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7aecd73)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request Sep 12, 2024
…ntrol visualizations (#8108) (#8141)

* Correct the size of disabled ValidatedDualRange components in InputControl visualizations



* Changeset file for PR #8108 created/updated

* Update snapshot



---------



(cherry picked from commit 7aecd73)

Signed-off-by: Miki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
virajsanghvi pushed a commit that referenced this pull request Sep 12, 2024
…ntrol visualizations (#8108) (#8142)

* Correct the size of disabled ValidatedDualRange components in InputControl visualizations



* Changeset file for PR #8108 created/updated

* Update snapshot



---------



(cherry picked from commit 7aecd73)

Signed-off-by: Miki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants