-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the size of disabled ValidatedDualRange components in InputControl visualizations #8108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
September 10, 2024 16:20
opensearch-changeset-bot bot
added a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Sep 10, 2024
LDrago27
previously approved these changes
Sep 10, 2024
virajsanghvi
previously approved these changes
Sep 10, 2024
opensearch-changeset-bot bot
added a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Sep 10, 2024
opensearch-changeset-bot
bot
dismissed stale reviews from virajsanghvi and LDrago27
via
September 10, 2024 18:00
76977f7
AMoo-Miki
changed the title
Correctly size of disabled ValidatedDualRange components in InputControl visualizations
Correct size of disabled ValidatedDualRange components in InputControl visualizations
Sep 10, 2024
LDrago27
previously approved these changes
Sep 10, 2024
virajsanghvi
previously approved these changes
Sep 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8108 +/- ##
=======================================
Coverage 63.71% 63.71%
=======================================
Files 3738 3738
Lines 88682 88699 +17
Branches 13788 13793 +5
=======================================
+ Hits 56501 56516 +15
+ Misses 31593 31592 -1
- Partials 588 591 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
opensearch-changeset-bot bot
added a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Sep 10, 2024
opensearch-changeset-bot
bot
dismissed stale reviews from virajsanghvi and LDrago27
via
September 10, 2024 18:28
483f9f0
…ntrol visualizations Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
post-header
branch
from
September 10, 2024 18:30
483f9f0
to
732befe
Compare
AMoo-Miki
changed the title
Correct size of disabled ValidatedDualRange components in InputControl visualizations
Correct the size of disabled ValidatedDualRange components in InputControl visualizations
Sep 10, 2024
LDrago27
previously approved these changes
Sep 10, 2024
virajsanghvi
previously approved these changes
Sep 10, 2024
Signed-off-by: Miki <[email protected]>
AMoo-Miki
dismissed stale reviews from virajsanghvi and LDrago27
via
September 10, 2024 20:01
a1d4c9c
sejli
approved these changes
Sep 10, 2024
virajsanghvi
approved these changes
Sep 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…ntrol visualizations (#8108) * Correct the size of disabled ValidatedDualRange components in InputControl visualizations Signed-off-by: Miki <[email protected]> * Changeset file for PR #8108 created/updated * Update snapshot Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 7aecd73) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…ntrol visualizations (#8108) * Correct the size of disabled ValidatedDualRange components in InputControl visualizations Signed-off-by: Miki <[email protected]> * Changeset file for PR #8108 created/updated * Update snapshot Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 7aecd73) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Sep 12, 2024
…ntrol visualizations (#8108) (#8141) * Correct the size of disabled ValidatedDualRange components in InputControl visualizations * Changeset file for PR #8108 created/updated * Update snapshot --------- (cherry picked from commit 7aecd73) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
virajsanghvi
pushed a commit
that referenced
this pull request
Sep 12, 2024
…ntrol visualizations (#8108) (#8142) * Correct the size of disabled ValidatedDualRange components in InputControl visualizations * Changeset file for PR #8108 created/updated * Update snapshot --------- (cherry picked from commit 7aecd73) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correctly size of disabled ValidatedDualRange components in InputControl visualizations
Screenshot
Before:
After:
Changelog
Check List
yarn test:jest
yarn test:jest_integration