-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[navigation]feat: add sample data
menu back
#8076
[navigation]feat: add sample data
menu back
#8076
Conversation
Signed-off-by: SuZhou-Joe <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8076 +/- ##
==========================================
+ Coverage 60.58% 60.60% +0.01%
==========================================
Files 3738 3738
Lines 88671 88677 +6
Branches 13782 13784 +2
==========================================
+ Hits 53724 53741 +17
+ Misses 31662 31650 -12
- Partials 3285 3286 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: SuZhou-Joe <[email protected]>
@@ -31,7 +32,9 @@ export const getPrincipalsFromRequest = ( | |||
if (authState?.authInfo?.backend_roles) { | |||
payload[PrincipalType.Groups] = authState.authInfo.backend_roles; | |||
} | |||
if (authState?.authInfo?.user_name) { | |||
if (authState?.authInfo?.user_id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated, is it by accident?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, as the change is minor so I want to include the change into in this PR as well. No need to raise a new PR for such 1 line change.
category: DEFAULT_APP_CATEGORIES.manageWorkspace, | ||
order: 300, | ||
}, | ||
{ | ||
id: WORKSPACE_DETAIL_APP_ID, | ||
id: 'import_sample_data', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still have sample data card in overview pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we still need the menu in left nav or the bread crumb info of sample data page will be broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am having a hard time finding the Add Sample Data card in the workspaces other than Search. Is this something we added in the past day or two?
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8076-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 faac756e4c6985e7a3dd7a62dc25e9a3b624b0d9
# Push it to GitHub
git push --set-upstream origin backport/backport-8076-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8076-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 faac756e4c6985e7a3dd7a62dc25e9a3b624b0d9
# Push it to GitHub
git push --set-upstream origin backport/backport-8076-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17 Then, create a pull request where the |
* feat: add sample data back Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR opensearch-project#8076 created/updated * fix: unit test failure Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit faac756)
* feat: add sample data back Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #8076 created/updated * fix: unit test failure Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit faac756)
* feat: add sample data back Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #8076 created/updated * fix: unit test failure Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit faac756) (cherry picked from commit 0a42d64) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat: add sample data back Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #8076 created/updated * fix: unit test failure Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit faac756) (cherry picked from commit 0a42d64) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat: add sample data back * Changeset file for PR #8076 created/updated * fix: unit test failure --------- (cherry picked from commit faac756) (cherry picked from commit 0a42d64) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* feat: add sample data back * Changeset file for PR #8076 created/updated * fix: unit test failure --------- (cherry picked from commit faac756) (cherry picked from commit 0a42d64) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
In release 2.17 we won't make import sample data into a modal so we need to add the menu back.
Issues Resolved
Screenshot
Testing the changes
Changelog
sample data
menu backCheck List
yarn test:jest
yarn test:jest_integration