Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header look and feel changes #8064

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

LDrago27
Copy link
Collaborator

@LDrago27 LDrago27 commented Sep 6, 2024

Description

The changes in the PR aims at improving the look and feel of the Application header.

  • Change the titles of new Dashboard - New dashboard, Visualization - New visualization, Discover - New search
  • Fix padding & spacing issues in visualization landing page
  • Fix margin for the Add an existing object to the dashboard wizard

Issues Resolved

Screenshot

image

image

image

Testing the changes

Changelog

  • Fix header look and feel changes for Discover, Dashboards and Visualization Pages

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Invalid Prefix

Invalid description prefix. Found "Fix header look and feel changes for Discover, Dashboards and Visualization Pages". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.60%. Comparing base (4776fcd) to head (47f8c1d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...components/dashboard_top_nav/dashboard_top_nav.tsx 0.00% 0 Missing and 1 partial ⚠️
...s_react/public/table_list_view/table_list_view.tsx 0.00% 1 Missing ⚠️
..._builder/public/application/components/top_nav.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8064      +/-   ##
==========================================
+ Coverage   60.59%   60.60%   +0.01%     
==========================================
  Files        3738     3738              
  Lines       88645    88647       +2     
  Branches    13765    13767       +2     
==========================================
+ Hits        53714    53728      +14     
+ Misses      31653    31641      -12     
  Partials     3278     3278              
Flag Coverage Δ
Linux_1 28.76% <0.00%> (-0.01%) ⬇️
Linux_2 56.27% <ø> (ø)
Linux_3 37.51% <0.00%> (+<0.01%) ⬆️
Linux_4 29.61% <0.00%> (-0.01%) ⬇️
Windows_1 28.79% <0.00%> (+0.01%) ⬆️
Windows_2 56.22% <ø> (ø)
Windows_3 37.51% <0.00%> (-0.01%) ⬇️
Windows_4 29.61% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki
Copy link
Collaborator

Note: The space below the search box will be addressed when opensearch-project/oui#1391 lands in OSD.

@ashwin-pc ashwin-pc merged commit ecd33b0 into opensearch-project:main Sep 9, 2024
70 of 71 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 9, 2024
Signed-off-by: Suchit Sahoo <[email protected]>
(cherry picked from commit ecd33b0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 9, 2024
Signed-off-by: Suchit Sahoo <[email protected]>
(cherry picked from commit ecd33b0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Sep 10, 2024
(cherry picked from commit ecd33b0)

Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Sep 10, 2024
(cherry picked from commit ecd33b0)

Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants