Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 2.17][Workspace] Add User level setting (#7953) #8058

Conversation

Hailong-am
Copy link
Collaborator

Backport 569b70d from (#7953)

(cherry picked from commit 569b70d)
Signed-off-by: Hailong Cui <[email protected]>
@Hailong-am Hailong-am changed the title [Manul backport 2.17][Workspace] Add User level setting (#7953) [Manual backport 2.17][Workspace] Add User level setting (#7953) Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 67.48971% with 79 lines in your changes missing coverage. Please review.

Please upload report for BASE (2.17@0d6c74b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/plugins/workspace/server/utils.ts 5.55% 17 Missing ⚠️
src/core/server/ui_settings/ui_settings_client.ts 77.55% 4 Missing and 7 partials ⚠️
...rkspace/public/components/workspace_list/index.tsx 80.39% 7 Missing and 3 partials ⚠️
src/plugins/advanced_settings/public/plugin.ts 43.75% 8 Missing and 1 partial ⚠️
...d_settings/public/management_app/user_settings.tsx 64.28% 4 Missing and 1 partial ⚠️
src/plugins/workspace/server/routes/index.ts 0.00% 5 Missing ⚠️
...ntent_management/public/components/page_render.tsx 55.55% 2 Missing and 2 partials ⚠️
src/plugins/workspace/public/plugin.ts 50.00% 3 Missing and 1 partial ⚠️
...r/saved_objects/user_ui_settings_client_wrapper.ts 91.89% 1 Missing and 2 partials ⚠️
...ade_saved_config/create_or_upgrade_saved_config.ts 66.66% 1 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files
@@           Coverage Diff           @@
##             2.17    #8058   +/-   ##
=======================================
  Coverage        ?   60.67%           
=======================================
  Files           ?     3737           
  Lines           ?    88657           
  Branches        ?    13770           
=======================================
  Hits            ?    53792           
  Misses          ?    31585           
  Partials        ?     3280           
Flag Coverage Δ
Linux_1 28.77% <34.91%> (?)
Linux_2 56.38% <70.58%> (?)
Linux_3 37.54% <43.42%> (?)
Linux_4 29.73% <8.33%> (?)
Windows_1 28.78% <34.91%> (?)
Windows_2 56.34% <70.58%> (?)
Windows_3 37.54% <43.42%> (?)
Windows_4 29.73% <8.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki
Copy link
Collaborator

Closing in favor of a new backport.

@AMoo-Miki AMoo-Miki closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants