[discover] undefined datasource fix for index patterns for PPL and SQL #8027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deconstructing the dataSource caused an exception when no dataSource was set with the query. Accessing by dot notation with null operator fixes this issue. Adding tests to prevent this happening again Signed-off-by: Kawika Avilla <[email protected]>
kavilla
requested review from
ananzh,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
ashwin-pc
approved these changes
Sep 5, 2024
github-actions
bot
added
the
Skip-Changelog
kavilla
changed the title
kavilla
changed the title
sejli
approved these changes
Sep 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8027 +/- ##
==========================================
+ Coverage 60.55% 60.58% +0.03%
==========================================
Files 3732 3732
Lines 88425 88425
Branches 13700 13700
==========================================
+ Hits 53547 53575 +28
+ Misses 31621 31590 -31
- Partials 3257 3260 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
cypress existing flakey need to look into that. seems highlighting is rendering slower than cypress expected. that or it's not in view |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…#8027) Deconstructing the dataSource caused an exception when no dataSource was set with the query. This can be the case with index patterns that are created and pointed to the default. Most times the default is the local cluster so there is no data source object in the query the case of the local. Accessing by dot notation with null operator fixes this issue. Adding tests to prevent this happening again. With query enhancements enabled we should considered ensuring index patterns always have a datasource object in the query. Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 06816d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…#8027) Deconstructing the dataSource caused an exception when no dataSource was set with the query. This can be the case with index patterns that are created and pointed to the default. Most times the default is the local cluster so there is no data source object in the query the case of the local. Accessing by dot notation with null operator fixes this issue. Adding tests to prevent this happening again. With query enhancements enabled we should considered ensuring index patterns always have a datasource object in the query. Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 06816d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Sep 5, 2024
…#8027) (#8028) Deconstructing the dataSource caused an exception when no dataSource was set with the query. This can be the case with index patterns that are created and pointed to the default. Most times the default is the local cluster so there is no data source object in the query the case of the local. Accessing by dot notation with null operator fixes this issue. Adding tests to prevent this happening again. With query enhancements enabled we should considered ensuring index patterns always have a datasource object in the query. (cherry picked from commit 06816d5) Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Sep 5, 2024
…#8027) (#8029) Deconstructing the dataSource caused an exception when no dataSource was set with the query. This can be the case with index patterns that are created and pointed to the default. Most times the default is the local cluster so there is no data source object in the query the case of the local. Accessing by dot notation with null operator fixes this issue. Adding tests to prevent this happening again. With query enhancements enabled we should considered ensuring index patterns always have a datasource object in the query. (cherry picked from commit 06816d5) Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deconstructing the dataSource caused an exception when no dataSource was set with the query. This can be the case with index patterns that are created and pointed to the
default. Most times the default is the local cluster so there is no data source object in the query the case of the local.Accessing by dot notation with null operator fixes this issue. Adding tests to prevent this happening again.
With query enhancements enabled we should considered ensuring index patterns always have a datasource object in the query.
Issues Resolved
Index patterns failed on SQL and PPL
Screenshot
URL:
query:(dataset:(id:d3d7af60-4c81-11e8-b3d7-01146121b73d,timeFieldName:timestamp,title:opensearch_dashboards_sample_data_flights,type:INDEX_PATTERN),Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration