-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][discover] PPL and SQL use default internal search route #8019
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8019 +/- ##
==========================================
- Coverage 60.60% 60.54% -0.06%
==========================================
Files 3738 3738
Lines 88669 88679 +10
Branches 13782 13783 +1
==========================================
- Hits 53734 53692 -42
- Misses 31650 31705 +55
+ Partials 3285 3282 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kawika Avilla <[email protected]>
ce1852e
to
8f5649a
Compare
@@ -37,6 +33,12 @@ export const getFields = (rawResponse: any) => { | |||
})); | |||
}; | |||
|
|||
export const getQuery = (searchRequest: IOpenSearchDashboardsSearchRequest): Query => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parses query
will close but will track this to avoid the clutter but this should still be done. |
Description
commit currently doesn't work.
likely because we need to parse the bare minimum required request for PPL endpoints as it seems to be sending too much an error.
After all the refactoring for 2.17. The default /internal/search with search strategy is now usable. Effectly ensuring we are using no new API routes.
also i think this should fix the issue where index patterns dont work with ppl and sql (could be a new issue)
Issues Resolved
n/a
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration