-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auto Suggest] Look and Feel changes #7991
[Auto Suggest] Look and Feel changes #7991
Conversation
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7991 +/- ##
==========================================
- Coverage 60.58% 60.58% -0.01%
==========================================
Files 3732 3732
Lines 88427 88436 +9
Branches 13701 13703 +2
==========================================
+ Hits 53577 53582 +5
- Misses 31591 31594 +3
- Partials 3259 3260 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
* put in trigger suggest on focus and on type space Signed-off-by: Paul Sebastian <[email protected]> * modify dql suggestions to keep suggestion chaining fluid Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR #7991 created/updated * user hints Signed-off-by: Paul Sebastian <[email protected]> * specify dql operators in details and icon Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR #7991 created/updated * Changeset file for PR #7991 created/updated * update testing constants Signed-off-by: Paul Sebastian <[email protected]> * modify scss Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR #7991 created/updated --------- Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 4776fcd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* put in trigger suggest on focus and on type space Signed-off-by: Paul Sebastian <[email protected]> * modify dql suggestions to keep suggestion chaining fluid Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR #7991 created/updated * user hints Signed-off-by: Paul Sebastian <[email protected]> * specify dql operators in details and icon Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR #7991 created/updated * Changeset file for PR #7991 created/updated * update testing constants Signed-off-by: Paul Sebastian <[email protected]> * modify scss Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR #7991 created/updated --------- Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 4776fcd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* put in trigger suggest on focus and on type space Signed-off-by: Paul Sebastian <[email protected]> * modify dql suggestions to keep suggestion chaining fluid Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR opensearch-project#7991 created/updated * user hints Signed-off-by: Paul Sebastian <[email protected]> * specify dql operators in details and icon Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR opensearch-project#7991 created/updated * Changeset file for PR opensearch-project#7991 created/updated * update testing constants Signed-off-by: Paul Sebastian <[email protected]> * modify scss Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR opensearch-project#7991 created/updated --------- Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* put in trigger suggest on focus and on type space * modify dql suggestions to keep suggestion chaining fluid * Changeset file for PR #7991 created/updated * user hints * specify dql operators in details and icon * Changeset file for PR #7991 created/updated * Changeset file for PR #7991 created/updated * update testing constants * modify scss * Changeset file for PR #7991 created/updated --------- (cherry picked from commit 4776fcd) Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* put in trigger suggest on focus and on type space * modify dql suggestions to keep suggestion chaining fluid * Changeset file for PR #7991 created/updated * user hints * specify dql operators in details and icon * Changeset file for PR #7991 created/updated * Changeset file for PR #7991 created/updated * update testing constants * modify scss * Changeset file for PR #7991 created/updated --------- (cherry picked from commit 4776fcd) Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* put in trigger suggest on focus and on type space Signed-off-by: Paul Sebastian <[email protected]> * modify dql suggestions to keep suggestion chaining fluid Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR opensearch-project#7991 created/updated * user hints Signed-off-by: Paul Sebastian <[email protected]> * specify dql operators in details and icon Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR opensearch-project#7991 created/updated * Changeset file for PR opensearch-project#7991 created/updated * update testing constants Signed-off-by: Paul Sebastian <[email protected]> * modify scss Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR opensearch-project#7991 created/updated --------- Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Videos
Light Mode:
Screen.Recording.2024-09-04.at.2.38.27.PM.mov
Dark Mode:
Screen.Recording.2024-09-04.at.2.41.26.PM.mov
Changes
Keeping the suggestion window open
This PR aims to keep the suggestion window open as long as possible by doing the following three things:
Part of the behavior that already exists is that the suggestion window will close when the user presses ESC
User hints below suggestions
This change appends user hints below the suggestion window:
Tab to insert, ESC to close window
. It does this through scssDQL Operators
AND
,OR
, andNOT
have been distinguished as operators - the details and the icon have been changedAlso, DQL Autocomplete was modified slightly to work better with change number 3. PPL and SQL will also have to be modified, because currently the cursor is still sitting on the previous word so the next suggestions aren't available until a space is put.
Changelog