Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] refactor: Update page header for edit object page #7963

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[Backport 2.x] refactor: Update page header for edit object page #7963

merged 1 commit into from
Sep 3, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 054186f from #7910.

@github-actions @opensearch-changeset-bot @SuZhou-Joe
refactor: Update page header for edit object page (#7910)
95d5f3d 
* refactor: update page header for edit object page

Signed-off-by: tygao <[email protected]>

* Changeset file for PR #7910 created/updated

* style: update paddingSize of settings page

Signed-off-by: tygao <[email protected]>

* test: add mock for test cases

Signed-off-by: tygao <[email protected]>

* style: update title size

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 054186f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports all-star-contributor workspace v2.17.0 labels Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (0c7b210) to head (95d5f3d).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...nagement_section/object_view/components/header.tsx 33.33% 0 Missing and 2 partials ⚠️
...gement/public/management_section/mount_section.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #7963      +/-   ##
==========================================
- Coverage   61.01%   61.01%   -0.01%     
==========================================
  Files        3670     3670              
  Lines       86747    86750       +3     
  Branches    13331    13335       +4     
==========================================
+ Hits        52930    52931       +1     
- Misses      30621    30622       +1     
- Partials     3196     3197       +1
Flag Coverage Δ
Linux_1 28.90% <0.00%> (-0.01%) ⬇️
Linux_2 56.15% <ø> (ø)
Linux_3 37.98% <0.00%> (+<0.01%) ⬆️
Linux_4 29.78% <25.00%> (-0.01%) ⬇️
Windows_1 28.92% <0.00%> (-0.01%) ⬇️
Windows_2 56.10% <ø> (ø)
Windows_3 37.98% <0.00%> (-0.01%) ⬇️
Windows_4 29.78% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit bbcdcd3 into 2.x Sep 3, 2024
67 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
all-star-contributor autocut Skip the changelog verification check on backports failed changeset v2.17.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruanyl @SuZhou-Joe