Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 2.x] Add Dynamic Config Service to Core Service (#7194) #7958

Merged

Conversation

huyaboo
Copy link
Member

@huyaboo huyaboo commented Sep 2, 2024

Manual backports of #7194 #7901 and #7922

Add Dynamic Config Service to Core Service (#7194)

  • Add dynamic config service to core

Signed-off-by: Huy Nguyen [email protected]

  • Add opensearch client implementation

Signed-off-by: Huy Nguyen [email protected]

  • Add descriptions for the DAO clients

Signed-off-by: Huy Nguyen [email protected]

  • Refactor DynamicConfigService

Signed-off-by: Huy Nguyen [email protected]

  • Refactor dynamic config service start

Signed-off-by: Huy Nguyen [email protected]


Signed-off-by: Huy Nguyen [email protected]
(cherry picked from commit 8a96664)

Fix issue when bootstrapping on 2.x (#7901)

  • Fix issue bootstrapping dynamic config service

Signed-off-by: Huy Nguyen [email protected]


Signed-off-by: Huy Nguyen [email protected]
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 07504f6)

Fix mock import (#7922)

Signed-off-by: Huy Nguyen [email protected]
(cherry picked from commit b370871)

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

* Add dynamic config service to core

Signed-off-by: Huy Nguyen <[email protected]>

* Add opensearch client implementation

Signed-off-by: Huy Nguyen <[email protected]>

* Add descriptions for the DAO clients

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor DynamicConfigService

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor dynamic config service start

Signed-off-by: Huy Nguyen <[email protected]>

---------

Signed-off-by: Huy Nguyen <[email protected]>
(cherry picked from commit 8a96664)

Fix issue when bootstrapping on 2.x (opensearch-project#7901)

* Fix issue bootstrapping dynamic config service

Signed-off-by: Huy Nguyen <[email protected]>

* Changeset file for PR opensearch-project#7901 created/updated

---------

Signed-off-by: Huy Nguyen <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 07504f6)

Fix mock import (opensearch-project#7922)

Signed-off-by: Huy Nguyen <[email protected]>
(cherry picked from commit b370871)
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@huyaboo huyaboo changed the title Add Dynamic Config Service to Core Service (#7194) [Manual backport 2.x] Add Dynamic Config Service to Core Service (#7194) Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@huyaboo huyaboo marked this pull request as ready for review September 2, 2024 04:15
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@huyaboo huyaboo requested a review from joshuali925 as a code owner September 2, 2024 04:15
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 75.35714% with 69 lines in your changes missing coverage. Please review.

Project coverage is 61.06%. Comparing base (cf6255c) to head (98a3269).
Report is 6 commits behind head on 2.x.

Files with missing lines Patch % Lines
src/core/server/config/dynamic_config_service.ts 57.14% 19 Missing and 5 partials ⚠️
...server/config/service/configuration_client.mock.ts 43.47% 13 Missing ⚠️
...g/service/internal_dynamic_configuration_client.ts 71.42% 7 Missing and 3 partials ⚠️
src/core/server/config/utils/utils.ts 66.66% 10 Missing ⚠️
src/core/server/core_route_handler_context.ts 20.00% 4 Missing ⚠️
...ver/config/service/dynamic_configuration_client.ts 25.00% 3 Missing ⚠️
...ig_store_client/opensearch_config_store_factory.ts 0.00% 2 Missing ⚠️
.../core/server/config/dynamic_config_service.mock.ts 94.44% 0 Missing and 1 partial ⚠️
...fig_store_client/opensearch_config_store_client.ts 98.70% 0 Missing and 1 partial ⚠️
src/core/server/rendering/rendering_service.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7958      +/-   ##
==========================================
+ Coverage   61.01%   61.06%   +0.04%     
==========================================
  Files        3670     3682      +12     
  Lines       86748    87024     +276     
  Branches    13332    13364      +32     
==========================================
+ Hits        52931    53137     +206     
- Misses      30621    30681      +60     
- Partials     3196     3206      +10     
Flag Coverage Δ
Linux_1 28.83% <12.04%> (-0.07%) ⬇️
Linux_2 56.34% <73.83%> (+0.18%) ⬆️
Linux_3 37.85% <14.18%> (-0.12%) ⬇️
Linux_4 29.69% <12.04%> (-0.09%) ⬇️
Windows_1 28.85% <12.04%> (-0.08%) ⬇️
Windows_2 56.29% <73.83%> (+0.18%) ⬆️
Windows_3 37.86% <14.18%> (-0.12%) ⬇️
Windows_4 29.69% <12.04%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT BionIT merged commit 3a4c984 into opensearch-project:2.x Sep 3, 2024
64 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants