-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Fix dynamicConfigServiceMock import path in workspace routes UT #7954
[Workspace]Fix dynamicConfigServiceMock import path in workspace routes UT #7954
Conversation
Signed-off-by: Lin Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7954 +/- ##
==========================================
+ Coverage 60.99% 61.01% +0.02%
==========================================
Files 3684 3685 +1
Lines 87141 87142 +1
Branches 13403 13403
==========================================
+ Hits 53151 53170 +19
+ Misses 30775 30754 -21
- Partials 3215 3218 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7954-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 976c5677fa27a440e88924a658435329d02b3f56
# Push it to GitHub
git push --set-upstream origin backport/backport-7954-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…es UT (opensearch-project#7954) * Fix dynamicConfigServiceMock import path in workspace routes UT Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR opensearch-project#7954 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* [Workspace]Validate features parameter in workspace create and update API (#7884) * Add validate for features field in workspace create and update API Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7884 created/updated * Changeset file for PR #7884 created/updated * Move router outside align with other plugins Signed-off-by: Lin Wang <[email protected]> * Add ut and fix integration tests Signed-off-by: Lin Wang <[email protected]> * Import use case id from default nav groups Signed-off-by: Lin Wang <[email protected]> * Fix workspace routes UT Signed-off-by: Lin Wang <[email protected]> * Share feature config generator between publicn and server Signed-off-by: Lin Wang <[email protected]> * Fix osd server crashed due to import from public Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Workspace]Fix dynamicConfigServiceMock import path in workspace routes UT (#7954) * Fix dynamicConfigServiceMock import path in workspace routes UT Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7954 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* [Workspace]Validate features parameter in workspace create and update API (#7884) * Add validate for features field in workspace create and update API Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7884 created/updated * Changeset file for PR #7884 created/updated * Move router outside align with other plugins Signed-off-by: Lin Wang <[email protected]> * Add ut and fix integration tests Signed-off-by: Lin Wang <[email protected]> * Import use case id from default nav groups Signed-off-by: Lin Wang <[email protected]> * Fix workspace routes UT Signed-off-by: Lin Wang <[email protected]> * Share feature config generator between publicn and server Signed-off-by: Lin Wang <[email protected]> * Fix osd server crashed due to import from public Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Workspace]Fix dynamicConfigServiceMock import path in workspace routes UT (#7954) * Fix dynamicConfigServiceMock import path in workspace routes UT Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7954 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit d3ce40f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [Workspace]Validate features parameter in workspace create and update API (#7884) * Add validate for features field in workspace create and update API * Changeset file for PR #7884 created/updated * Changeset file for PR #7884 created/updated * Move router outside align with other plugins * Add ut and fix integration tests * Import use case id from default nav groups * Fix workspace routes UT * Share feature config generator between publicn and server * Fix osd server crashed due to import from public --------- * [Workspace]Fix dynamicConfigServiceMock import path in workspace routes UT (#7954) * Fix dynamicConfigServiceMock import path in workspace routes UT * Changeset file for PR #7954 created/updated --------- --------- (cherry picked from commit d3ce40f) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
The
dynamicConfigServiceMock
has been changed in this PR. Current PR is for fixingdynamicConfigServiceMock
was missing error. This PR will import dynamicConfigServiceMock fromcore/server/mocks
directly.Issues Resolved
#7955
Screenshot
No UI Changes
Testing the changes
yarn osd bootstrap
yarn test:jest src/plugins/workspace/server/routes/index.test.ts
Changelog
Check List
yarn test:jest
yarn test:jest_integration